Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Don't call method on null WalletModel object #10242

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
5 participants
@ryanofsky
Copy link
Contributor

commented Apr 20, 2017

This doesn't crash currently because the method doesn't access any object
members, but this behavior is fragile and incompatible with #10102.

[qt] Don't call method on null WalletModel object
This doesn't crash currently because the method doesn't access any object
members, but this behavior is fragile and incompatible with #10102.
@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Apr 20, 2017

Uh. Yes. That makes much more sense.
Thanks for fixing.

utACK 7ba5539

@luke-jr

This comment has been minimized.

Copy link
Member

commented Apr 20, 2017

Ouch, utACK.

@ryanofsky

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2017

If anyone wants to add a tested ack, easiest way to test this is to start bitcoin-qt with -walletrbf flag, and make sure "Request Replace-By-Fee" checkbox is checked, then start without the -walletrbf flag and make sure the checkbox is unchecked.

You can find the "Request Replace-By-Fee" checkbox under "Send", "Transaction Fee", "Choose..."

@ryanofsky ryanofsky force-pushed the ryanofsky:pr/rbfnull branch from 7ba5539 to fb463d1 Apr 20, 2017

@mariodian

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2017

tACK (OS X 10.12.4)

@laanwj laanwj merged commit fb463d1 into bitcoin:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 21, 2017

Merge #10242: [qt] Don't call method on null WalletModel object
fb463d1 [qt] Don't call method on null WalletModel object (Russell Yanofsky)

Tree-SHA512: 84c9d394a16eb44e2673e7d16961ea9514fd0ef3912baf7cd7b8424a46ead138ac8ecc59c4eebfb46941fa3081555fd6ee15fec699a3952e81f960932e06cee0

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 15, 2017

[qt] Don't call method on null WalletModel object
This doesn't crash currently because the method doesn't access any object
members, but this behavior is fragile and incompatible with bitcoin#10102.

Github-Pull: bitcoin#10242
Rebased-From: fb463d1

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request May 10, 2019

Merge bitcoin#10242: [qt] Don't call method on null WalletModel object
fb463d1 [qt] Don't call method on null WalletModel object (Russell Yanofsky)

Tree-SHA512: 84c9d394a16eb44e2673e7d16961ea9514fd0ef3912baf7cd7b8424a46ead138ac8ecc59c4eebfb46941fa3081555fd6ee15fec699a3952e81f960932e06cee0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.