/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix some empty vector references #10250

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Utils and libraries
Projects
None yet
Milestone
No milestone
5 participants
@sipa @laanwj @theuni @paveljanik @jtimon
@sipa
Owner

sipa commented Apr 21, 2017 •
Edited 1 time

streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this. This problem does not manifest in practice (yet), it seems.

Discovered by @theuni.
@sipa
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.
f478d98

@sipa sipa referenced this pull request Apr 21, 2017

Merged

Switch chainstate db and cache to per-txout model #10195

@laanwj
Owner

laanwj commented Apr 21, 2017

utACK f478d98

@laanwj laanwj added the Utils and libraries label Apr 21, 2017

@theuni
Member

theuni commented Apr 21, 2017

utACK f478d98
@paveljanik
Contributor

paveljanik commented Apr 21, 2017

utACK f478d98

@laanwj laanwj merged commit f478d98 into bitcoin:master Apr 21, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 21, 2017

@laanwj
Merge #10250: Fix some empty vector references 
f478d98 Fix some empty vector references (Pieter Wuille)

Tree-SHA512: a22022b9060cd39f8d349e8dd24490614c0028eae2fbc7186d0d26b1d47529049b2daee41f093c0722130274a0b6f7f8671c2295c8cb4a97028771eaff080734
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
1428f30
@jtimon
Member

jtimon commented Apr 24, 2017

post-merge utACK f478d98

@theuni theuni referenced this pull request May 8, 2017

Merged

Rewrite addrdb with less duplication using CHashVerifier #10248

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jun 3, 2017

@sipa @luke-jr
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
dbfb1f3

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jun 3, 2017

@sipa @luke-jr
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
2b1608b

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jun 3, 2017

@sipa @luke-jr
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
bc51694

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jun 5, 2017

@sipa @luke-jr
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
ef924c5

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jun 5, 2017

@sipa @luke-jr
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
69fda1b

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Jun 5, 2017

@sipa @luke-jr
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
e23cef0

@sipa sipa deleted the sipa:nonnullref branch Jun 23, 2017

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Jul 17, 2017

@sipa @nomnombtc
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
bd52b4d

@ptschip ptschip referenced this pull request in BitcoinUnlimited/BitcoinUnlimited Oct 3, 2017

Merged

dbcache phase 3 enhancements #785

runn1ng added a commit to runn1ng/bitcoin that referenced this pull request Oct 30, 2017

@sipa @runn1ng
Fix some empty vector references 
streams.h has some methods that can be tricked into dereferencing
null pointers or end() iterators. Fix this.

Github-Pull: #10250
Rebased-From: f478d98
948688b

codablock added a commit to codablock/dash that referenced this pull request Oct 31, 2017

@laanwj @codablock
Merge #10250: Fix some empty vector references 
f478d98 Fix some empty vector references (Pieter Wuille)

Tree-SHA512: a22022b9060cd39f8d349e8dd24490614c0028eae2fbc7186d0d26b1d47529049b2daee41f093c0722130274a0b6f7f8671c2295c8cb4a97028771eaff080734
6cf97b5

codablock added a commit to codablock/dash that referenced this pull request Oct 31, 2017

@laanwj @codablock
Merge #10250: Fix some empty vector references 
f478d98 Fix some empty vector references (Pieter Wuille)

Tree-SHA512: a22022b9060cd39f8d349e8dd24490614c0028eae2fbc7186d0d26b1d47529049b2daee41f093c0722130274a0b6f7f8671c2295c8cb4a97028771eaff080734
8ed6722

@codablock codablock referenced this pull request in dashpay/dash Oct 31, 2017

Merged

Backport bitcoin perutxo #1701

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Nov 8, 2017

@laanwj @UdjinM6
Merge #10250: Fix some empty vector references 
f478d98 Fix some empty vector references (Pieter Wuille)

Tree-SHA512: a22022b9060cd39f8d349e8dd24490614c0028eae2fbc7186d0d26b1d47529049b2daee41f093c0722130274a0b6f7f8671c2295c8cb4a97028771eaff080734
b22c2b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment