Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] remove minimum total fee option #10390

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
9 participants
@instagibbs
Copy link
Member

instagibbs commented May 12, 2017

It's of questionable use and complicates further wallet improvements.

@gmaxwell

This comment has been minimized.

Copy link
Member

gmaxwell commented May 12, 2017

We had a minimum total fee? Thats useless.. Concept ACK getting rid of it.

@fanquake fanquake added the Wallet label May 12, 2017

@MarcoFalke MarcoFalke added the GUI label May 14, 2017

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented May 14, 2017

Concept ACK. It might be useful in some edge cases, but I don't think this entitles for cluttering the gui and wallet code with this option.

@sipa

This comment has been minimized.

Copy link
Member

sipa commented May 14, 2017

utACK. Seems untested even.

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented May 17, 2017

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented May 19, 2017

utACK 091a9ae
Couldn't seem to find any more related code that should have also been removed.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented May 22, 2017

utACK 091a9ae

@laanwj laanwj merged commit 091a9ae into bitcoin:master May 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 22, 2017

Merge #10390: [wallet] remove minimum total fee option
091a9ae remove minimum total fee option (Gregory Sanders)

Tree-SHA512: 9be4df3dab0219f30917211408f47b242f7c96dd7663b06ab1cf3cc63027f14956dc680883be6c58673b6452d0f339cf893694e4f21d0d248e70760614d5a344
@morcos

This comment has been minimized.

Copy link
Member

morcos commented May 22, 2017

woohoo!
sorry i didn't ACK this

@markblundeberg

This comment has been minimized.

Copy link

markblundeberg commented Feb 16, 2019

(note: introduced bug later fixed in #11332)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.