New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bytes_serialized with bogosize #10426

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
4 participants
@sipa
Member

sipa commented May 18, 2017

Current result:

  "bogosize": 3846482678,
  "disk_size": 2272310093,
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 19, 2017

Member

Looks like you'll need to update the blockchain RPC test here.

Member

fanquake commented May 19, 2017

Looks like you'll need to update the blockchain RPC test here.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 19, 2017

Member

Fixed.

Member

sipa commented May 19, 2017

Fixed.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 19, 2017

Member

Nice, concept ACK

Member

laanwj commented May 19, 2017

Nice, concept ACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 19, 2017

Member
Member

MarcoFalke commented May 19, 2017

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 19, 2017

Member

I've rebased this PR on top of #10396, as both touch the same code. A single combined release-notes.md entry was added.

Member

sipa commented May 19, 2017

I've rebased this PR on top of #10396, as both touch the same code. A single combined release-notes.md entry was added.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 30, 2017

Member

Rebased, and updated the release notes a bit.

Member

sipa commented May 30, 2017

Rebased, and updated the release notes a bit.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 1, 2017

Member

Rebased on top of #10195.

Member

sipa commented Jun 1, 2017

Rebased on top of #10195.

Show outdated Hide outdated src/rpc/blockchain.cpp Outdated
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 6, 2017

Member

tested ACK 8b22af3

Member

laanwj commented Jun 6, 2017

tested ACK 8b22af3

@laanwj laanwj merged commit 8b22af3 into bitcoin:master Jun 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 6, 2017

Merge #10426: Replace bytes_serialized with bogosize
8b22af3 Replace bytes_serialized with bogosize (Pieter Wuille)

Tree-SHA512: e70a981bbb977329f9e324c45f9a1346ec9aacfbbad5474e608cdd1f852257502bb7db8003fd578260a609e45d1a9cf87ce96df9c4187d92d50f60a209e232ce

@sipa sipa deleted the sipa:bogosize branch Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment