-bip148 option #10532
Closed
-bip148 option #10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, just the DoS rework/fixes are in #10512 |
|
Travis failure is due to I think.... |
Correct - on Travis it's a failure condition to have a functional test that isn't included in either |
… we're relying on them as a primary node
luke-jr
force-pushed
the
bip148
branch
2 times, most recently
from
03f2d8b
to
f8b9080
Compare
Basic functional test for behaviour with -bip148 flag.
|
Is this branch actively maintained / usable / recommended? Is there a reason why it's not in the upstream? (I don't follow bitcoin-dev mailing list) |
|
@Runn1ng For now, I would recommend users upgrade to https://github.com/UASF/bitcoin/ |
|
Yes, the UASF branch is there, this one doesn't seem to be maintained actively (not even the travis issue has been fixed). |
|
@luke-jr Thanks! Would you recommend to use |
|
Either should be fine. |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 4, 2017
Basic functional test for behaviour with -bip148 flag. Github-Pull: bitcoin#10532 Rebased-From: a050dab870e5c2fc4ee801fa3a4d87bd8c6aa38e
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 4, 2017
Github-Pull: bitcoin#10532 Rebased-From: a170d5f8bdae0f17b4b9c575b159015a538e1166
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 4, 2017
Github-Pull: bitcoin#10532 Rebased-From: 349f5e92961d057c06cca29538ef270a521995eb
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 4, 2017
…ny blocks Github-Pull: bitcoin#10532 Rebased-From: 824d9e1f5c44a5f63bde870542ffd2e04dc0abca
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Github-Pull: bitcoin#10532 Rebased-From: 8f8ee034f6265e34b467ba7d558636f4fcff9e76 Rebased-From: 7ab3e4b
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Github-Pull: bitcoin#10532 Rebased-From: 54f292ba0bf3a6844c83ad3b5fbc720f68bda419 Rebased-From: 4fb5da5
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Github-Pull: bitcoin#10532 Rebased-From: 8b997ed656713ab959ddca651395c3ac7703580d Rebased-From: 04dca27
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
…pruned, error immediately, rather than silently fail to rewind Github-Pull: bitcoin#10532 Rebased-From: b59c910 Rebased-From: 6048d3e
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Github-Pull: bitcoin#10532 Rebased-From: cd74a23fcf9588199e196ab31bc64972400c2027 Rebased-From: 19d638e
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
… risk Github-Pull: bitcoin#10532 Rebased-From: e42a2f6beb61df3e3a201804cf3bcce6b00c88ba Rebased-From: 8c6816f
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Basic functional test for behaviour with -bip148 flag. Github-Pull: bitcoin#10532 Rebased-From: a050dab870e5c2fc4ee801fa3a4d87bd8c6aa38e Rebased-From: 493f3ef
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Github-Pull: bitcoin#10532 Rebased-From: a170d5f8bdae0f17b4b9c575b159015a538e1166 Rebased-From: 181a850
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
Github-Pull: bitcoin#10532 Rebased-From: 349f5e92961d057c06cca29538ef270a521995eb Rebased-From: 94923d5
luke-jr
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jul 17, 2017
…ny blocks Github-Pull: bitcoin#10532 Rebased-From: 824d9e1f5c44a5f63bde870542ffd2e04dc0abca Rebased-From: 08c5702
|
This can be closed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on luke-jr's "non-dos(100)" version of the code, it is mutually exclusive with #10442. More discussion is in #10428.