New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC]Move transaction combining from signrawtransaction to new RPC #10571

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
7 participants
@achow101
Member

achow101 commented Jun 10, 2017

Create a combinerawtransaction RPC which accepts a json array of hex raw transactions to combine them into one transaction. Signrawtransaction is changed to no longer combine transactions and only accept one transaction at a time.

The tests have been updated to test this. Tests for the signrawtransaction merge have also been removed.

This is part of #10570

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 12, 2017

Member

Concept ACK. However, this does break backward compatibility with an undocumented but apparently intentional and tested feature. Does this require deprecation first?

Member

sipa commented Jun 12, 2017

Concept ACK. However, this does break backward compatibility with an undocumented but apparently intentional and tested feature. Does this require deprecation first?

@jnewbery

This comment has been minimized.

Show comment
Hide comment
@jnewbery

jnewbery Jun 28, 2017

Member

Concept feedback: combining transactions seems like a utility. Is it possible to add it to bitcoin-tx rather than add a utility-only RPC?

Member

jnewbery commented Jun 28, 2017

Concept feedback: combining transactions seems like a utility. Is it possible to add it to bitcoin-tx rather than add a utility-only RPC?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 28, 2017

Member

It is not a utility-only RPC. It needs access to the UTXO set.

Member

sipa commented Jun 28, 2017

It is not a utility-only RPC. It needs access to the UTXO set.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jul 15, 2017

Member

utACK c710eb9

Member

sipa commented Jul 15, 2017

utACK c710eb9

@gmaxwell

ACK

@morcos

morcos approved these changes Jul 17, 2017

utACK c710eb9

although at least the documentation in the RPC test should probably be corrected

Show outdated Hide outdated src/rpc/rawtransaction.cpp Outdated
Show outdated Hide outdated src/rpc/rawtransaction.cpp Outdated
Show outdated Hide outdated test/functional/rawtransactions.py Outdated
@achow101

This comment has been minimized.

Show comment
Hide comment
@achow101

achow101 Jul 17, 2017

Member

Nits addressed and rebased.

Member

achow101 commented Jul 17, 2017

Nits addressed and rebased.

@morcos

This comment has been minimized.

Show comment
Hide comment
@morcos

morcos Jul 17, 2017

Member

@achow101 It's better if you address the nits separately from rebasing (was rebasing needed?) otherwise its hard to review just the differential and reACK.

Member

morcos commented Jul 17, 2017

@achow101 It's better if you address the nits separately from rebasing (was rebasing needed?) otherwise its hard to review just the differential and reACK.

@achow101

This comment has been minimized.

Show comment
Hide comment
@achow101

achow101 Jul 17, 2017

Member

@morcos sorry, I rebased out of habit.

Member

achow101 commented Jul 17, 2017

@morcos sorry, I rebased out of habit.

@achow101

This comment has been minimized.

Show comment
Hide comment
@achow101

achow101 Jul 17, 2017

Member

Now the comment should be right.

Member

achow101 commented Jul 17, 2017

Now the comment should be right.

@morcos

This comment has been minimized.

Show comment
Hide comment
@morcos

morcos Jul 17, 2017

Member

heh thanks...
and i think its ok to squash, especially if the old commit can still be found, b/c then a diff btwn old and new can show the differences. it's the rebase that makes it difficult

utACK f293282

Member

morcos commented Jul 17, 2017

heh thanks...
and i think its ok to squash, especially if the old commit can still be found, b/c then a diff btwn old and new can show the differences. it's the rebase that makes it difficult

utACK f293282

@morcos

This comment has been minimized.

Show comment
Hide comment
@morcos

morcos Jul 17, 2017

Member

utACK 3cd7a5b

Member

morcos commented Jul 17, 2017

utACK 3cd7a5b

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jul 17, 2017

Member

utACK 3cd7a5b

Member

sipa commented Jul 17, 2017

utACK 3cd7a5b

Show outdated Hide outdated src/rpc/rawtransaction.cpp Outdated
Move transaction combining from signrawtransaction to new RPC
Create a combinerawtransaction RPC which accepts a json array of hex raw
transactions to combine them into one transaction. Signrawtransaction is changed
to no longer combine transactions and only accept one transaction at a time.

@laanwj laanwj merged commit 6b4f231 into bitcoin:master Jul 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 20, 2017

Merge #10571: [RPC]Move transaction combining from signrawtransaction…
… to new RPC

6b4f231 Move transaction combining from signrawtransaction to new RPC (Andrew Chow)

Pull request description:

  Create a combinerawtransaction RPC which accepts a json array of hex raw transactions to combine them into one transaction. Signrawtransaction is changed to no longer combine transactions and only accept one transaction at a time.

  The tests have been updated to test this. Tests for the signrawtransaction merge have also been removed.

  This is part of #10570

Tree-SHA512: 035aebbd6537c1c017d5c8e06d309228b4c23fe52d5b31ffde19741c81a11a6346ddbbdc582b77b02a47f4c22b1952b69d3c2ee1109c29b3f0f1b612d8de53ed

@TheBlueMatt TheBlueMatt referenced this pull request Jul 23, 2017

Closed

TODO for release notes 0.15.0 #9889

12 of 12 tasks complete

@achow101 achow101 deleted the achow101:combineraw-rpc branch Aug 29, 2017

sipa added a commit that referenced this pull request Feb 20, 2018

Merge #10579: [RPC] Split signrawtransaction into wallet and non-wall…
…et RPC command

d602348 Add test for signrawtransaction (Andrew Chow)
eefff65 scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests (Andrew Chow)
1e79c05 Split signrawtransaction into wallet and non-wallet (Andrew Chow)

Pull request description:

  This PR is part of #10570. It also builds on top of #10571.

  This PR splits `signrawtransaction` into two commands, `signrawtransactionwithkey` and `signrawtransactionwithwallet`. `signrawtransactionwithkey` requires private keys to be passed in and does not use the wallet for any signing. `signrawtransactionwithwallet` uses the wallet to sign a raw transaction and does not have any parameters to take private keys.

  The `signrawtransaction` RPC has been marked as deprecated and will call the appropriate RPC command based upon the parameters given. A test was added to check this behavior is still consistent with the original behavior.

  All tests that used `signrawtransaction` have been updated to use one of the two new RPCs. Most uses were changed to `signrawtransactionwithwallet`. These were changed via a scripted diff.

Tree-SHA512: d0adf5b4cd7077639c504ec07bee262a3b94658d34db0a5c86a263b6393f7aa62f45129eafe29a7c861aa58440dd19348ee0c8b685e8a62d6f4adae8ec8f8cb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment