/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfix: net: Apply whitelisting criteria to outgoing connections #10594

Open
wants to merge 1 commit into
from
+5 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
P2P
Projects
None yet
Milestone
No milestone
5 participants
@luke-jr @practicalswift @sipa @laanwj @fanquake
@luke-jr
Member

luke-jr commented Jun 14, 2017

Whitelisting currently only works for inbound connections, but would be useful for outgoing just as well.

@luke-jr luke-jr referenced this pull request Jun 14, 2017

Closed

-bip148 option #10532

@practicalswift
Contributor

practicalswift commented Jun 14, 2017

Concept ACK, but the documentation for -whitelist would need to be updated updated as well?

@fanquake fanquake added the P2P label Jun 15, 2017

@luke-jr
Member

luke-jr commented Jun 15, 2017

(Updated docs)
@practicalswift
Contributor

practicalswift commented Jun 15, 2017

utACK a511b89
@sipa
Owner

sipa commented Jun 16, 2017

utACK
@laanwj
Owner

laanwj commented Jun 24, 2017

What is the difference with #10051 by @rubensayshi?
Anyhow, at least @gmaxwell didn't think it was a good idea there, should probably keep the discussion in one place...

@luke-jr luke-jr referenced this pull request in UASF/bitcoin Jul 4, 2017

Merged

Bugfix: net: Apply whitelisting criteria to outgoing connections #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment