New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: net: Apply whitelisting criteria to outgoing connections #10594

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@luke-jr
Member

luke-jr commented Jun 14, 2017

Whitelisting currently only works for inbound connections, but would be useful for outgoing just as well.

@luke-jr luke-jr referenced this pull request Jun 14, 2017

Closed

-bip148 option #10532

@practicalswift

This comment has been minimized.

Show comment
Hide comment
@practicalswift

practicalswift Jun 14, 2017

Member

Concept ACK, but the documentation for -whitelist would need to be updated updated as well?

Member

practicalswift commented Jun 14, 2017

Concept ACK, but the documentation for -whitelist would need to be updated updated as well?

@fanquake fanquake added the P2P label Jun 15, 2017

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jun 15, 2017

Member

(Updated docs)

Member

luke-jr commented Jun 15, 2017

(Updated docs)

@practicalswift

This comment has been minimized.

Show comment
Hide comment
@practicalswift
Member

practicalswift commented Jun 15, 2017

utACK a511b89

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 16, 2017

Member

utACK

Member

sipa commented Jun 16, 2017

utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 24, 2017

Member

What is the difference with #10051 by @rubensayshi?
Anyhow, at least @gmaxwell didn't think it was a good idea there, should probably keep the discussion in one place...

Member

laanwj commented Jun 24, 2017

What is the difference with #10051 by @rubensayshi?
Anyhow, at least @gmaxwell didn't think it was a good idea there, should probably keep the discussion in one place...

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 9, 2018

Member

Needs rebase if still relevant

Member

MarcoFalke commented May 9, 2018

Needs rebase if still relevant

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 24, 2018

Member

Closing, this has been inactive for too long.

Member

laanwj commented Jun 24, 2018

Closing, this has been inactive for too long.

@laanwj laanwj closed this Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment