Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: net: Apply whitelisting criteria to outgoing connections #10594

Closed
wants to merge 1 commit into from

Conversation

@luke-jr
Copy link
Member

luke-jr commented Jun 14, 2017

Whitelisting currently only works for inbound connections, but would be useful for outgoing just as well.

@luke-jr luke-jr force-pushed the luke-jr:whitelist_outgoing branch Jun 14, 2017
@luke-jr luke-jr mentioned this pull request Jun 14, 2017
@practicalswift
Copy link
Member

practicalswift commented Jun 14, 2017

Concept ACK, but the documentation for -whitelist would need to be updated updated as well?

@fanquake fanquake added the P2P label Jun 15, 2017
@luke-jr luke-jr force-pushed the luke-jr:whitelist_outgoing branch to a511b89 Jun 15, 2017
@luke-jr
Copy link
Member Author

luke-jr commented Jun 15, 2017

(Updated docs)

@practicalswift
Copy link
Member

practicalswift commented Jun 15, 2017

utACK a511b89

@sipa
Copy link
Member

sipa commented Jun 16, 2017

utACK

@laanwj
Copy link
Member

laanwj commented Jun 24, 2017

What is the difference with #10051 by @rubensayshi?
Anyhow, at least @gmaxwell didn't think it was a good idea there, should probably keep the discussion in one place...

@luke-jr luke-jr force-pushed the luke-jr:whitelist_outgoing branch from a511b89 to 416f9b9 Nov 6, 2017
@MarcoFalke
Copy link
Member

MarcoFalke commented May 9, 2018

Needs rebase if still relevant

@laanwj
Copy link
Member

laanwj commented Jun 24, 2018

Closing, this has been inactive for too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.