Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make feebumper class stateless #10600
+111
−119
Conversation
fanquake
added the
Wallet
label
Jun 15, 2017
ryanofsky
referenced
this pull request
Jun 15, 2017
Open
[qt] Add abstraction layer for accessing node and wallet functionality from gui #10244
|
Why bother with the class? |
I don't see a problem with using a class as a namespace, but happy to change if you think it is in bad taste and have a different suggestion. Note that the files are called feebumper.h/cpp so if you want to replace the class with something else, it might involve file renames. This PR is really more concerned with simplifying Qt code and moving code that doesn't belong there out. |
ryanofsky
referenced
this pull request
Jun 19, 2017
Open
bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP, Depends on #10244) #10102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ryanofsky commentedJun 15, 2017
Make feebumper methods static and remove stored state in the class.
Having the results of feebumper calls persist in an object makes process
separation between Qt and wallet awkward, because it means the feebumper object
either has to be serialized back and forth between Qt and wallet processes
between fee bump calls, or that the feebumper object needs to stay alive in the
wallet process with an object reference passed back to Qt. It's simpler just to
have fee bumper calls return their results immediately instead of storing them
in an object with an extended lifetime.
In addition to making feebumper methods static, also:
updated in this PR anyway so this doesn't increase the size of the diff)
This change was originally part of #10244