Verify binaries from bitcoincore.org and bitcoin.org

[TheBlueMatt]

In preparation for moving the "official" binary host to bitcoincore.org, use it for verifybinaries (and compare with bitcoin.org).

[sipa]

Does this need such hardcoding for those two specific hosts, as opposed to a for HOST in bitcoin.org bitcoincore.org; do loop?

[TheBlueMatt]

I mean that's just as much hard coding since it only downloads the binaries from one of the two (and unless you want to depend on bash for arrays.....).

…

On June 22, 2017 9:22:05 PM EDT, Pieter Wuille ***@***.***> wrote: Does this need such hardcoding for those two specific hosts, as opposed to a `for HOST in bitcoin.org bitcoincore.org` loop?

[sipa]

I see a wget from both?

[TheBlueMatt]

With a very different error message on both :p

…

On June 22, 2017 9:37:47 PM EDT, Pieter Wuille ***@***.***> wrote: I see a wget from both?

[sipa]

That seems a silly complication to justify duplicating the logic. Just say "failed to download file X from host Y".

[TheBlueMatt]

Well the first error message correctly highlights that it is most likely the user's fault (bad version string), whereas the second is mostly likely servers acting up. Could go further and attempt to download both in any case, however.

…

On June 22, 2017 9:41:12 PM EDT, Pieter Wuille ***@***.***> wrote: That seems a silly complication to justify duplicating the logic. Just say "failed to download file X from host Y".

[TheBlueMatt]

@sipa I added the array-based version at TheBlueMatt/bitcoin@3a60faa its more code, and IMO more complex, but if you still prefer it we can do that?

[laanwj]

I mean that's just as much hard coding since it only downloads the binaries from one of the two (and unless you want to depend on bash for arrays.....).

I can't believe we're having a discussion whether to use arrays in 2017. Shellscript is horrible.

(Concept ACK anyhow - I leave all implementation details to you)

[TheBlueMatt]

Heh, well I realized this script is already full of bashism, so I dont really care either way...its more code with the arrays but if we ever plan on adding more mirrors (I dont think so?) then it might be helpful.

[jtimon]

Concept ACK

[laanwj]

So, okay, can we make a decision here? Arrays or not? Should we throw a coin?

[TheBlueMatt]

Coin sounds good. My very weak vote is leave it as-is cause I find it less confusing, but dont care strongly either way.

[sipa]

If it is this complicated, I retract my suggestion :)

[laanwj]

Just going to merge this, it's outrageous to keep tools/tests pulls like this open if they simply do correctly what they should do. Cleaning up the code can be done later.