Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
document script-based return fields for validateaddress #10676
+8
−0
Conversation
fanquake
added the
Docs and Output
label
Jun 27, 2017
|
utACK f9dc6e5 |
laanwj
self-assigned this
Jun 28, 2017
| @@ -174,6 +174,14 @@ UniValue validateaddress(const JSONRPCRequest& request) | ||
| " \"ismine\" : true|false, (boolean) If the address is yours or not\n" | ||
| " \"iswatchonly\" : true|false, (boolean) If the address is watchonly\n" | ||
| " \"isscript\" : true|false, (boolean) If the key is a script\n" | ||
| + " \"script\" : \"type\" (string, optional) The output script type. Possible types: nonstandard, pubkey, pubkeyhash, scripthash, multisig, nulldata, witness_v0_keyhash, witness_v0_scripthash\n" |
jonasschnelli
Jun 28, 2017
Member
I guess this and L178 needs two whitespace more for the correct indentation...
jonasschnelli
Jun 29, 2017
Member
L176 has two escapes (2x \") while this line has four escapes. I'd expect that it will be off by two whitespace against the other lines.
instagibbs
Jun 29, 2017
Member
I'm matching lines 185 through 187 at least, should those be indented further as well?
|
@jonasschnelli nit addressed |
laanwj
merged commit f2f1d0a
into
bitcoin:master
Jul 11, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
laanwj
added a commit
that referenced
this pull request
Jul 11, 2017
|
|
laanwj |
This commit was signed with a verified signature.
laanwj
Wladimir J. van der Laan
|
379aed0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
instagibbs commentedJun 27, 2017
No description provided.