/bitcoin

Avoid printing incorrect block indexing time due to uninitialized variable #10714

Merged
merged 1 commit into from Jul 12, 2017
+3 −1

Conversation

Reviewers

@gmaxwell gmaxwell

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
6 participants
@practicalswift @TheBlueMatt @jnewbery @gmaxwell @jonasschnelli @sipa
@practicalswift
Contributor

practicalswift commented Jul 2, 2017

Avoid printing incorrect block indexing time due to uninitialized variable.

Fixes:

init.cpp: In function ‘bool AppInitMain(boost::thread_group&, CScheduler&)’:
init.cpp:1499:56: warning: ‘nStart’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     LogPrintf(" block index %15dms\n", GetTimeMillis() - nStart);
                                                        ^

In this fix I've assumed that block indexing time is only relevant to print in case of fLoaded. Let me know if that assumption is incorrect.
@practicalswift practicalswift Avoid printing incorrect block indexing time due to uninitialized var… 
…iable

Fixes:

init.cpp: In function ‘bool AppInitMain(boost::thread_group&, CScheduler&)’:
init.cpp:1499:56: warning: ‘nStart’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     LogPrintf(" block index %15dms\n", GetTimeMillis() - nStart);
                                                        ^
959dd87

fanquake referenced this pull request Jul 7, 2017

Closed

Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp #10768

@TheBlueMatt
Contributor

TheBlueMatt commented Jul 7, 2017

utACK

jonasschnelli added the Refactoring label Jul 7, 2017

@gmaxwell

gmaxwell approved these changes Jul 9, 2017
View changes

utACK looks like the correct fix to me

@jnewbery
Member

jnewbery commented Jul 10, 2017

Tested ACK 959dd87.

TheBlueMatt referenced this pull request Jul 12, 2017

Merged

Avoid some new gcc warnings in 15 #10808

@sipa sipa merged commit 959dd87 into bitcoin:master Jul 12, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sipa sipa added a commit that referenced this pull request Jul 12, 2017

@sipa sipa Merge #10714: Avoid printing incorrect block indexing time due to uni… 
…nitialized variable


959dd87 Avoid printing incorrect block indexing time due to uninitialized variable (practicalswift)

Tree-SHA512: a76e43c3ffa734ed5c7eadf363f345f268aa0e6ce775aba8f856fe3bbc82f240dc7c734c5ca3ac500a12eb41fae00623413e79f484d5acf809b6e400851d771d
This commit was signed with a verified signature.
@sipa sipa Pieter Wuille
GPG key ID: A636E97631F767E0 Learn about signing commits
2a09a38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment