New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap EvalScript in a ScriptExecution class #10729

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@luke-jr
Member

luke-jr commented Jul 3, 2017

When we last discussed making scripts debuggable (sometime after #3901), the plan was to instead trace execution rather than single-step through it.

This is the first step toward that goal. The full implementation can be found on my script_debugger branch.

typedef std::vector<unsigned char> StackElementType;
typedef std::vector<StackElementType> StackType;
const CScript& script;

This comment has been minimized.

@promag

promag Jul 4, 2017

Member

Make these private?

@promag

promag Jul 4, 2017

Member

Make these private?

This comment has been minimized.

@luke-jr

luke-jr Jul 4, 2017

Member

They are meant for external inspection.

@luke-jr

luke-jr Jul 4, 2017

Member

They are meant for external inspection.

This comment has been minimized.

@promag

promag Jul 4, 2017

Member

When that happens either make it public, create a getter or an Inspect method?

@promag

promag Jul 4, 2017

Member

When that happens either make it public, create a getter or an Inspect method?

Show outdated Hide outdated src/script/interpreter.h
Show outdated Hide outdated src/script/interpreter.h
Show outdated Hide outdated src/script/interpreter.h
@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Sep 2, 2017

Member

Rebased

Member

luke-jr commented Sep 2, 2017

Rebased

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon Sep 6, 2017

Member

Concept ACK, will review

Member

jtimon commented Sep 6, 2017

Concept ACK, will review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment