[rpc] fix verbose argument for getblock in bitcoin-cli

[jnewbery]

Using the verbose option with getblock in bitcoin-cli has been broken since #8704:

→ bitcoin-cli -named getblock blockhash=0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206 verbose=true
error code: -1
error message:
JSON value is not a boolean as expected

→ bitcoin-cli -named getblock blockhash=0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206 verbosity=true
{
  "hash": "0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206",
...

In general, I think that adding aliases because some people find argument names distasteful is a bad idea since it leads to subtle bugs like this.

However, that functionality has already been merged in so I'm not going to try to undo it. This is the simplest fix for restoring the previous behavior.

@achow101 @luke-jr

[jonasschnelli]

I agree, we should not allow aliases (If possible, something API compatibility could require it) . Should we then get completely rid of the alias here: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L1542

The alias in general works, it's just the bitcoin-cli's JSON string-to-bool conversion that failed.

[achow101]

utACK 58e9864

[TheBlueMatt]

Not to blow a small fix into a big change, but is it possible to more easily ensure we dont break this stuff in the future (also generally issues in having typos between the server registration and client registration here scares me cause most of it is untested). Maybe the easiest way is to just add a python or bash script that checks for consistency ala our documentation-required-for-options checks?

[jnewbery]

is it possible to more easily ensure we dont break this stuff in the future

Yes, absolutely agree that there should be better testing (bitcoin-cli seems to be entirely untested). Can we open an issue to track that and treat this as a quick fix for the recent regression?

[TheBlueMatt]

@jnewbery fair enough. utACK 58e9864

[luke-jr]

The alias isn't about taste, but compatibility. bitcoin-cli is essentially just a testing tool, so I don't think it needs to itself be compatible (but I don't mind either).

[laanwj]

utACK 58e9864