Building Environment: Set ARFLAGS to cr

[ReneNyffenegger]

Override the default of ARFLAGS of cru to cr.

When building, ar produces a warning for each archive, for example

  AR       libbitcoin_server.a
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')

Since u is the default anyway, it cannot hurt to remove it.

[practicalswift]

Concept ACK

Nit: I don't think that u is the default - IIRC it is just that u optimization has no effect when running in deterministic mode (D), which is now the default.

[theuni]

Concept ACK. Though, please don't hard-code it to "cr" in case the change causes trouble for some toolchain. Let's use AC_ARG_VAR instead, so that it may be overridden if necessary:

AC_ARG_VAR(ARFLAGS, [flags passed to the archiver])
if test "x${ARFLAGS+set}" != "xset"; then
  ARFLAGS="cr"
fi

[ReneNyffenegger]

I agree / have created a hopefully improved pull request: 10782

[theuni]

Thanks. utACK after squash.

[jonasschnelli]

utACK bb4bb93
@ReneNyffenegger: can you squash the commits? Your first commit (bb4bb93) has "unrecoggnized author".

[ReneNyffenegger]

I've squashed to commits / Hope the user is now recognized.

[TheBlueMatt]

Concept ACK, though I tested and overriding doesnt work.

[TheBlueMatt]

Do you need the x${ARFLAGS+set} syntax that we use elsewhere?

[TheBlueMatt]

Maybe add D to the default here, so that we're consistent even on platforms with a strange ar build?

[ReneNyffenegger]

overriding didn't work.... because I goofed up when I manually tried to merge two branches: I had
if test "x${ARFLAGS}"...
instead of
if test "x${ARFLAGS+set}"...

With the fix, I've also added the D flag

[ReneNyffenegger]

Apparently, the D flag is not liked in the Darwin environment.

[TheBlueMatt]

Heh, ok, just leave it as cr I suppose.

[ReneNyffenegger]

I have removed the D flag again. Now, I have also commit 816aa59. I don't know why this is, if I should remove it, and how I could remove it.

[practicalswift]

@ReneNyffenegger Please do:

git rebase -i HEAD~2
# remove the line with "Fix multi_rpc test …"
git push -f

[ReneNyffenegger]

done rebase.

[practicalswift]

utACK 517bfb1

[TheBlueMatt]

ACK 912da1d. We'll need to do something about similar warnings in leveldb and secp256k1, but those will need to be submitted separately upstream.

[sipa]

utACK 912da1d

[practicalswift]

utACK 912da1d