/bitcoin

Simplify "!foo || (foo && bar)" as "!foo || bar" #10780

Merged
merged 1 commit into from Jul 13, 2017
+1 −1

Conversation

Reviewers

@dcousens dcousens

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
8 participants
@practicalswift @TheBlueMatt @promag @jnewbery @paveljanik @sipa @dcousens @fanquake
@practicalswift
Contributor

practicalswift commented Jul 9, 2017

Simplify !foo || (foo && bar) as !foo || bar.

Rationale:

  • Improve readability by removing redundant condition.

practicalswift changed the title from Simplify `!foo || (foo && bar)` as `!foo || bar` to Simplify "!foo || (foo && bar)" as "!foo || bar" Jul 9, 2017

fanquake added the Refactoring label Jul 9, 2017

@TheBlueMatt
Contributor

TheBlueMatt commented Jul 10, 2017

utACK
@promag
Contributor

promag commented Jul 10, 2017

utACK 1e3a320.
@jnewbery
Member

jnewbery commented Jul 10, 2017

utACK 1e3a320
@paveljanik
Contributor

paveljanik commented Jul 10, 2017

utACK 1e3a320
@sipa
Owner

sipa commented Jul 13, 2017

utACK 1e3a320

@sipa sipa merged commit 1e3a320 into bitcoin:master Jul 13, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sipa sipa added a commit that referenced this pull request Jul 13, 2017

@sipa sipa Merge #10780: Simplify "!foo || (foo && bar)" as "!foo || bar" 
1e3a320 Simplify "!foo || (foo && bar)" as "!foo || bar" (practicalswift)

Tree-SHA512: d5ce6d7a9f3741e7abe8542b840268aa683e276aac7587041d32385a4c1273e20c236bec7590e27540dde72defb3f879d4695822bb7bfdb092cc20d9aefa64c1
This commit was signed with a verified signature.
@sipa sipa Pieter Wuille
GPG key ID: A636E97631F767E0 Learn about signing commits
e4fcbf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment