/bitcoin

Replace MAX_OPCODE for OP_NOP10. #10792

Merged
merged 1 commit into from Jul 11, 2017
+4 −4

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
6 participants
@maaku @kallewoof @sipa @laanwj @MeshCollider @TheBlueMatt
@maaku
Contributor

maaku commented Jul 11, 2017

That OP_NOP10 is the last executable opcode is a bit of a obscure trivia, and the MAX_OPCODE constant already exists. This merely standardizes use of MAX_OPCODE over OP_NOP10 where it makes sense and is more clear.
@maaku maaku Replace MAX_OPCODE for OP_NOP10. 
That OP_NOP10 is the last executable opcode is a bit of a obscure trivia, and the MAX_OPCODE constant already exists. This merely standardizes use of MAX_OPCODE over OP_NOP10 where it makes sense and is more clear.
c8e29d7
@kallewoof
Contributor

kallewoof commented Jul 11, 2017

utACK c8e29d7
@sipa
Owner

sipa commented Jul 11, 2017

utACK c8e29d7. That's definitely clearer.
@laanwj
Owner

laanwj commented Jul 11, 2017

utACK
@MeshCollider

MeshCollider commented Jul 11, 2017

utACK c8e29d7

laanwj added the Refactoring label Jul 11, 2017

@laanwj laanwj merged commit c8e29d7 into bitcoin:master Jul 11, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laanwj laanwj added a commit that referenced this pull request Jul 11, 2017

@laanwj laanwj Merge #10792: Replace MAX_OPCODE for OP_NOP10. 
c8e29d7 Replace MAX_OPCODE for OP_NOP10. (Mark Friedenbach)

Tree-SHA512: f6a4129db24fe3feb044acaec3b94194cc4fa909de3d0a45a664b32f886a7d8ab997c9cb6ff0870c4aee66d8e038cf0453dbbb518316829d15e84da9882f3e69
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 1E4AED62986CD25D Learn about signing commits
badd81b
@TheBlueMatt
Contributor

TheBlueMatt commented Jul 11, 2017

utACK c8e29d7

TheBlueMatt referenced this pull request Jul 12, 2017

Merged

Avoid some new gcc warnings in 15 #10808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment