Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
[tests] skip zapwallettxes.py #10802
Conversation
fanquake
added the
Tests
label
Jul 12, 2017
|
Tend to NACK. I'd rather have just the fix merged than a total of three pulls. (disable test, fix interaction, enable test) |
|
Lets merge #10330! |
ok, let's merge it :) |
jnewbery
closed this
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jnewbery commentedJul 12, 2017
Temporary fix for #10678
zapwallettxes.py doesn't test anything due to a syntax error.
Fixing the syntax error causes the test to fail because of bad interaction between zapwallettxes and persistent mempool. There is a fix for that in #10330
Until #10330 is merged we should disable this test. There's no point in running a test that doesn't actually test anything, and which occasionally causes spurious Travis failures.