/bitcoin

Explicitly search for bdb5.3. #10803

Merged
merged 1 commit into from Jul 17, 2017
+1 −1

Conversation

Reviewers

@gmaxwell gmaxwell

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
7 participants
@pstratem @jonasschnelli @gmaxwell @luke-jr @laanwj @TheBlueMatt @sipa
@pstratem
Contributor

pstratem commented Jul 12, 2017

Some systems do not symlink the major version to the minor version.
@pstratem pstratem Explicitly search for bdb5.3. 
Some systems do not symlink the major version to the minor version.
1cc251f
@jonasschnelli
Member

jonasschnelli commented Jul 12, 2017

Should not hurt.
utACK 1cc251f
@gmaxwell

gmaxwell reviewed Jul 12, 2017 • edited
View changes

utACK. Should other versions be added too?

@pstratem
Contributor

pstratem commented Jul 12, 2017

The only things I've seen are 4.8 5.3 and versions under 4.8 which we probably dont want to every use.
@gmaxwell
Member

gmaxwell commented Jul 13, 2017

I believe 6 is a thing.
@pstratem
Contributor

pstratem commented Jul 14, 2017

@gmaxwell i've never actually seen 6.x on any system, but i guess no problem searching for it
@luke-jr
Member

luke-jr commented Jul 14, 2017

But BDB 6 is AGPL, which Bitcoin Core is not compliant with (the node would need to share its own source code to peers somehow).

laanwj added the Build system label Jul 14, 2017

@laanwj
Owner

laanwj commented Jul 14, 2017 • edited

I've never seen 6.x on a system either. Looks like the license change caused to fail adoption.

utACK 1cc251f

Edit: at least for ubuntu, bdb 6.0 was never packaged: https://packages.ubuntu.com/search?keywords=libdb&searchon=names&suite=yakkety&section=all . So we'd have no idea in what directory to look either.
@TheBlueMatt
Contributor

TheBlueMatt commented Jul 14, 2017

utACK 1cc251f
@sipa
Owner

sipa commented Jul 15, 2017

utACK 1cc251f

@laanwj laanwj merged commit 1cc251f into bitcoin:master Jul 17, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laanwj laanwj added a commit that referenced this pull request Jul 17, 2017

@laanwj laanwj Merge #10803: Explicitly search for bdb5.3. 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 1E4AED62986CD25D Learn about signing commits
91edda8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment