Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly search for bdb5.3. #10803

Merged
merged 1 commit into from Jul 17, 2017
Merged

Explicitly search for bdb5.3. #10803

merged 1 commit into from Jul 17, 2017

Conversation

pstratem
Copy link
Contributor

Some systems do not symlink the major version to the minor version.

@pstratem
Explicitly search for bdb5.3.
1cc251f 
Some systems do not symlink the major version to the minor version.
@jonasschnelli
Copy link
Contributor

Should not hurt.
utACK 1cc251f

gmaxwell
gmaxwell reviewed Jul 12, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Should other versions be added too?

@pstratem
Copy link
Contributor Author

The only things I've seen are 4.8 5.3 and versions under 4.8 which we probably dont want to every use.

@gmaxwell
Copy link
Contributor

I believe 6 is a thing.

@pstratem
Copy link
Contributor Author

@gmaxwell i've never actually seen 6.x on any system, but i guess no problem searching for it

@luke-jr
Copy link
Member

luke-jr commented Jul 14, 2017

But BDB 6 is AGPL, which Bitcoin Core is not compliant with (the node would need to share its own source code to peers somehow).

@laanwj
Copy link
Member

laanwj commented Jul 14, 2017 •
edited

I've never seen 6.x on a system either. Looks like the license change caused to fail adoption.

utACK 1cc251f

Edit: at least for ubuntu, bdb 6.0 was never packaged: https://packages.ubuntu.com/search?keywords=libdb&searchon=names&suite=yakkety&section=all . So we'd have no idea in what directory to look either.

@TheBlueMatt
Copy link
Contributor

utACK 1cc251f

1 similar comment
@sipa
Copy link
Member

sipa commented Jul 15, 2017

utACK 1cc251f

@laanwj laanwj merged commit 1cc251f into bitcoin:master Jul 17, 2017
laanwj added a commit that referenced this pull request Jul 17, 2017
@laanwj
Merge #10803: Explicitly search for bdb5.3.
91edda8 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
@dagurval dagurval mentioned this pull request Apr 26, 2018
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 6, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
68f6e24 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
df4e271 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 9, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
1e51c2b 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 11, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
b7b05be 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 13, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
28f21bb 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 13, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
44fcd73 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 17, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
ab5a244 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 23, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
e747e80 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 24, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10803: Explicitly search for bdb5.3.
9ad5330 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
barrystyle pushed a commit to PACGlobalOfficial/PAC that referenced this pull request Jan 22, 2020
@laanwj @barrystyle
Merge bitcoin#10803: Explicitly search for bdb5.3.
e6c93f7 
1cc251f Explicitly search for bdb5.3. (Patrick Strateman)

Pull request description:

  Some systems do not symlink the major version to the minor version.

Tree-SHA512: 09c030f08442cbe54928a6d20bec31aae2662facf60b859ff9febd84f0711f68d7f920b84fb015764585b305d48faf74c5fe9c3c6a713a0809b78ec066187dd9
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gmaxwell gmaxwell gmaxwell left review comments

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pstratem @jonasschnelli @gmaxwell @luke-jr @laanwj @TheBlueMatt @sipa @FornaxA