/bitcoin

missing white space in function arg #10810

Merged
merged 1 commit into from Jul 13, 2017
+1 −1

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@greenaddress @jnewbery @promag @jonasschnelli
@greenaddress
Contributor

greenaddress commented Jul 12, 2017

No description provided.

@jnewbery
Member

jnewbery commented Jul 12, 2017

utACK 7bf33a8
@promag
Contributor

promag commented Jul 12, 2017

NACK, I believe linting fixes should be avoided. Regarding this PR, there are lots of other cases.
@greenaddress greenaddress missing white space in function arg
This commit was signed with a verified signature.
@greenaddress greenaddress GreenAddress
GPG key ID: 17AB8BC320B151D8 Learn about signing commits
69a4339
@jonasschnelli
Member

jonasschnelli commented Jul 13, 2017

Agree with @promag, don't do such changes, the slow down everything while not really improving things.
utACK 69a4339

@jonasschnelli jonasschnelli merged commit 69a4339 into bitcoin:master Jul 13, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jonasschnelli jonasschnelli added a commit that referenced this pull request Jul 13, 2017

@jonasschnelli jonasschnelli Merge #10810: missing white space in function arg 
69a4339 missing white space in function arg (Lawrence Nahum)

Pull request description:

Tree-SHA512: 94d832eca0b5429cf48c7c1d4489942b53182c5b7ad9f24264867e7631301173c23a48f7b2e8fd22ff1b3137bafacb3f9d4320f4df235668c9096aaefff7afe8
This commit was signed with a verified signature.
@jonasschnelli jonasschnelli Jonas Schnelli
GPG key ID: 1EB776BB03C7922D Learn about signing commits
7666250
@greenaddress
Contributor

greenaddress commented Jul 13, 2017

@promag @jonasschnelli thanks for feedback, I was reviewing some code in the area and noticed the missing white space and thought about a mini PR - will avoid in the future.

greenaddress deleted the greenaddress:missing_white_space branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment