/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default #11026

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Docs and Output
Projects
None yet
Milestone
No milestone
7 participants
@luke-jr @sdaftuar @sipa @achow101 @MeshCollider @MarcoFalke @laanwj
@luke-jr
Member

luke-jr commented Aug 10, 2017 •
Edited 1 time

Fixes a bug introduced in #8855

-acceptnonstdtxn is a valid option only for testnet/regtest (in Core), and the help message reflects that. Currently, however, it is buggy in two ways:

  1. It uses mainnet to get the default value, which doesn't make sense since the option is never available for mainnet, and the only time the option is available, is when the default is the opposite.
  2. It uses the value of "require standard" directly as the default for "accept non-standard transactions", but these concepts are opposites: a negation must be performed to transform one to the other.

Note the combination of these bugs results in the correct boolean output, but the logic to get there is completely wrong.

@MarcoFalke MarcoFalke added the Docs and Output label Aug 10, 2017

@sdaftuar
Member

sdaftuar commented Aug 11, 2017

utACK
@sipa
Owner

sipa commented Aug 12, 2017

Care to elaborate a bit?
@luke-jr
Member

luke-jr commented Aug 13, 2017

-acceptnonstdtxn is a valid option only for testnet/regtest (in Core), and the help message reflects that. Currently, however, it is buggy in two ways:

  1. It uses mainnet to get the default value, which doesn't make sense since the option is never available for mainnet, and the only time the option is available, is when the default is the opposite.
  2. It uses the value of "require standard" directly as the default for "accept non-standard transactions", but these concepts are opposites: a negation must be performed to transform one to the other.

Note the combination of these bugs results in the correct boolean output, but the logic to get there is completely wrong.
@achow101
Member

achow101 commented Aug 18, 2017

utACK 4aa2508
@MeshCollider
Member

MeshCollider commented Aug 19, 2017

utACK 4aa2508

@laanwj laanwj merged commit 4aa2508 into bitcoin:master Aug 22, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 22, 2017

@laanwj
Merge #11026: Bugfix: Use testnet RequireStandard for -acceptnonstdtx… 
…n default


4aa2508 Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default (Luke Dashjr)

Pull request description:

  Fixes a bug introduced in #8855

  `-acceptnonstdtxn` is a valid option only for testnet/regtest (in Core), and the help message reflects that. Currently, however, it is buggy in two ways:

  1. It uses mainnet to get the default value, which doesn't make sense since the option is never available for mainnet, and the only time the option is available, is when the default is the opposite.
  2. It uses the value of "require standard" directly as the default for "accept non-standard transactions", but these concepts are opposites: a negation must be performed to transform one to the other.

  Note the combination of these bugs results in the correct boolean output, but the logic to get there is completely wrong.

Tree-SHA512: 06ce513f59ba31f7ab4b6422a08a17bb37a5652dea4c38a4bbefedd5e2752d17bfccc32a4b0508068fa4783e316bff00a821ef18a24b1a2bb02859995d188fdc
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 1E4AED62986CD25D Learn about signing commits
ea3ac59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment