Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitian: quick hack to fix version string in releases #11097

Merged
merged 1 commit into from Aug 21, 2017

Conversation

Projects
None yet
5 participants
@theuni
Copy link
Member

theuni commented Aug 19, 2017

Credit: @luke-jr
Release version strings were broken in Gitian by #7522. This is a minimal fix suitable for 0.15.

After this, we should fix up version handling for good so that gitian packages the correct string in the release tarball, so that git is not required to get the tag name.

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Aug 19, 2017

utACK

@fanquake fanquake added this to the 0.15.0 milestone Aug 20, 2017

gitian: quick hack to fix version string in releases
Release version strings were broken in Gitian by 7522. This is a minimal fix
suitable for 0.15.

After this, we should fix up version handling for good so that gitian packages
the correct string in the release tarball, so that git is not required to get
the tag name.

@theuni theuni force-pushed the theuni:gitian-version-fix branch to 4452829 Aug 20, 2017

@theuni

This comment has been minimized.

Copy link
Member Author

theuni commented Aug 20, 2017

I missed a removal of GIT_DIR in the osx descriptor. Pushed the fixed version, no other changes.

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Aug 20, 2017

utACK 4452829. @jonasschnelli Can spin up some test gitian builds?

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Aug 20, 2017

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Aug 21, 2017

utACK 4452829

@laanwj laanwj merged commit 4452829 into bitcoin:master Aug 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 21, 2017

Merge #11097: gitian: quick hack to fix version string in releases
4452829 gitian: quick hack to fix version string in releases (Cory Fields)

Pull request description:

  Credit: @luke-jr
  Release version strings were broken in Gitian by #7522. This is a minimal fix suitable for 0.15.

  After this, we should fix up version handling for good so that gitian packages the correct string in the release tarball, so that git is not required to get the tag name.

Tree-SHA512: fa609a744c46306b0809f08fed6e96eff41b13e82f3e213711e4abef370558b64a68972f283a038330882cb6c40b32547fbb0f89b8058cc2c6025bff134473c3

laanwj added a commit that referenced this pull request Aug 21, 2017

gitian: quick hack to fix version string in releases
Release version strings were broken in Gitian by 7522. This is a minimal fix
suitable for 0.15.

After this, we should fix up version handling for good so that gitian packages
the correct string in the release tarball, so that git is not required to get
the tag name.

Github-Pull: #11097
Rebased-From: 4452829
Tree-SHA512: 40071b97b2207b2262aef0b4802cb231ccafbff0ed04b5945a64dceda8bdbb2ea71bf6a546e1d03533612edfdc55dedd413da967cba0b1bbd3f9139ec3572f60

@laanwj laanwj removed the Needs backport label Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.