New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Make tabs toolbar no longer have a context menu #11169

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
6 participants
@achow101
Member

achow101 commented Aug 27, 2017

Adds a contextMenuPolicy of Qt::PreventContextMenu to prevent the tabs toolbar from showing a context menu that allows it to be hidden.

Fixes #11168

Make tabs toolbar no longer have a context menu
Adds a contextMenuPolicy of Qt::PreventContextMenu to prevent the
tabs toolbar from showing a context menu that allows it to be
hidden.

@fanquake fanquake added the GUI label Aug 27, 2017

@MeshCollider

This comment has been minimized.

Show comment
Hide comment
@MeshCollider

MeshCollider Aug 27, 2017

Member

Trivial utACK e254830, makes a lot of sense. Travis failure is with p2p-segwit, not related

Member

MeshCollider commented Aug 27, 2017

Trivial utACK e254830, makes a lot of sense. Travis failure is with p2p-segwit, not related

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 27, 2017

Member

Concept ACK

Member

sipa commented Aug 27, 2017

Concept ACK

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Aug 27, 2017

Member

Concept ACK

Member

MarcoFalke commented Aug 27, 2017

Concept ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Aug 28, 2017

Member

Tested ACK e254830
I'm surprised this we discover this hidden "feature" only now.

Member

laanwj commented Aug 28, 2017

Tested ACK e254830
I'm surprised this we discover this hidden "feature" only now.

@laanwj laanwj merged commit e254830 into bitcoin:master Aug 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 28, 2017

Merge #11169: [GUI] Make tabs toolbar no longer have a context menu
e254830 Make tabs toolbar no longer have a context menu (Andrew Chow)

Pull request description:

  Adds a contextMenuPolicy of Qt::PreventContextMenu to prevent the tabs toolbar from showing a context menu that allows it to be hidden.

  Fixes #11168

Tree-SHA512: 8900b3c1a891ead3c9a20dc365b436fa75f97dbe0dfa7e20ee26fd9d09f3fee6eda286b0c075ed89fe1361608ecbdd87c744e37d97a3fba62493a86dedda867b

@achow101 achow101 deleted the achow101:rm-hide-tabs branch Aug 29, 2017

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Sep 2, 2017

Make tabs toolbar no longer have a context menu
Adds a contextMenuPolicy of Qt::PreventContextMenu to prevent the
tabs toolbar from showing a context menu that allows it to be
hidden.

Github-Pull: #11169
Rebased-From: e254830

@achow101 achow101 restored the achow101:rm-hide-tabs branch Aug 17, 2018

@achow101 achow101 deleted the achow101:rm-hide-tabs branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment