Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Check connectivity before sending in assumevalid.py #11345

Merged
merged 1 commit into from Sep 18, 2017

Conversation

@jnewbery
Copy link
Member

commented Sep 15, 2017

assumevalid.py would try to send over a closed P2P connection in a loop,
hitting the following failure many times:

TestFramework.mininode (ERROR): Cannot send message. No connection to node!

The test still passed, but this is a lot of noise in the test log.

Just check that the connection is open before trying to send.

assumevalid.py would try to send over a closed P2P connection in a loop,
hitting the following failure many times:

TestFramework.mininode (ERROR): Cannot send message. No connection to node!

The test still passes, but this is a lot of noise in the test log.

Just check that the connection is open before trying to send.
@theuni

This comment has been minimized.

Copy link
Member

commented Sep 15, 2017

utACK e9e9391

@fanquake fanquake added the Tests label Sep 15, 2017
@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Sep 18, 2017

utACK e9e9391

@MarcoFalke MarcoFalke merged commit e9e9391 into bitcoin:master Sep 18, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
MarcoFalke added a commit that referenced this pull request Sep 18, 2017
…d.py

e9e9391 [tests] Check connectivity before sending in assumevalid.py (John Newbery)

Pull request description:

  assumevalid.py would try to send over a closed P2P connection in a loop,
  hitting the following failure many times:

  `TestFramework.mininode (ERROR): Cannot send message. No connection to node!`

  The test still passed, but this is a lot of noise in the test log.

  Just check that the connection is open before trying to send.

Tree-SHA512: 6faf2ce5717de976fed1b5c863bc8d17e785928690f833d5bf175178f95d39f455635a844fe7e0dfdad83ae779dd45bc6e4ed89a9467d8482c5be73b55095c8d
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Oct 3, 2017
assumevalid.py would try to send over a closed P2P connection in a loop,
hitting the following failure many times:

TestFramework.mininode (ERROR): Cannot send message. No connection to node!

The test still passes, but this is a lot of noise in the test log.

Just check that the connection is open before trying to send.

Github-Pull: bitcoin#11345
Rebased-From: e9e9391
codablock added a commit to codablock/dash that referenced this pull request Jun 23, 2019
…umevalid.py

e9e9391 [tests] Check connectivity before sending in assumevalid.py (John Newbery)

Pull request description:

  assumevalid.py would try to send over a closed P2P connection in a loop,
  hitting the following failure many times:

  `TestFramework.mininode (ERROR): Cannot send message. No connection to node!`

  The test still passed, but this is a lot of noise in the test log.

  Just check that the connection is open before trying to send.

Tree-SHA512: 6faf2ce5717de976fed1b5c863bc8d17e785928690f833d5bf175178f95d39f455635a844fe7e0dfdad83ae779dd45bc6e4ed89a9467d8482c5be73b55095c8d
codablock added a commit to codablock/dash that referenced this pull request Jun 23, 2019
…umevalid.py

e9e9391 [tests] Check connectivity before sending in assumevalid.py (John Newbery)

Pull request description:

  assumevalid.py would try to send over a closed P2P connection in a loop,
  hitting the following failure many times:

  `TestFramework.mininode (ERROR): Cannot send message. No connection to node!`

  The test still passed, but this is a lot of noise in the test log.

  Just check that the connection is open before trying to send.

Tree-SHA512: 6faf2ce5717de976fed1b5c863bc8d17e785928690f833d5bf175178f95d39f455635a844fe7e0dfdad83ae779dd45bc6e4ed89a9467d8482c5be73b55095c8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.