Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused functions and methods #11385

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
7 participants
@sipa
Copy link
Member

commented Sep 22, 2017

In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Remove some unused functions and methods
In the case of CKey's destructor, it seems to have been an oversight in
f4d1fc2 not to delete it. At this point, it results in the move
constructors/assignment operators for CKey being deleted, which may have
a performance impact.
@theuni

This comment has been minimized.

Copy link
Member

commented Sep 22, 2017

utACK 46c9043.

Out of curiosity, did you just happen upon CKey's useless dtor? I noticed some of these a while back which I believe have been fixed (CScript/prevector iirc), but if there's some simple static analysis tool that points them out, I'd like to get all of 'em.

@sipa

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2017

@theuni No tools, just stumbled upon it.

@promag

This comment has been minimized.

Copy link
Member

commented Sep 22, 2017

utACK 46c9043.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Sep 22, 2017

utACK 46c9043

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 22, 2017

utACK 46c9043

@laanwj laanwj merged commit 46c9043 into bitcoin:master Sep 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 22, 2017

Merge #11385: Remove some unused functions and methods
46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

  In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
  a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request May 15, 2019

Merge #11385: Remove some unused functions and methods
Summary:
46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

  In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
  a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

Backport of Core PR11385
bitcoin/bitcoin#11385

Test Plan:
  make check
  test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3044

jonspock added a commit to devaultcrypto/devault that referenced this pull request Jun 13, 2019

Merge #11385: Remove some unused functions and methods
Summary:
46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

  In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
  a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

Backport of Core PR11385
bitcoin/bitcoin#11385

Test Plan:
  make check
  test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3044

jonspock added a commit to jonspock/devault that referenced this pull request Jun 13, 2019

Merge #11385: Remove some unused functions and methods
Summary:
46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

  In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
  a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

Backport of Core PR11385
bitcoin/bitcoin#11385

Test Plan:
  make check
  test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3044

jonspock added a commit to devaultcrypto/devault that referenced this pull request Jun 13, 2019

Merge #11385: Remove some unused functions and methods
Summary:
46c9043 Remove some unused functions and methods (Pieter Wuille)

Pull request description:

  In the case of CKey's destructor, it seems to have been an oversight in #8753 not to delete it. At this point, it results in the move constructors/assignment operators for CKey being deleted, which may have
  a performance impact (requiring a pool allocation/copy/free, rather than just handing over the pointer from one CKey to another)

Tree-SHA512: 89715bafe3e0bea2c46fc92bc6a1010360a3fee2719f97b81ca379581003409b0876b50f992208a3c13c7f5b77f1866db09954e7d102f6a452fe5d7aed2044a1

Backport of Core PR11385
bitcoin/bitcoin#11385

Test Plan:
  make check
  test_runner.py

Reviewers: jasonbcox, deadalnix, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.