Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Policy] Several transaction standardness rules #11423

Merged
merged 4 commits into from May 12, 2018
Merged

[Policy] Several transaction standardness rules #11423

merged 4 commits into from May 12, 2018

Commits on May 4, 2018

  1. Add constant scriptCode policy in non-segwit scripts 

    This disables OP_CODESEPARATOR in non-segwit scripts (even in an unexecuted branch), and makes a positive FindAndDelete result invalid. This ensures that the scriptCode serialized in SignatureHash() is always the same as the script passing to the EvalScript.
    @jl2012
    jl2012 committed May 4, 2018
    1
    Copy the full SHA
    9dabfe4 View commit details
    Browse the repository at this point in the history

  2. Add transaction tests for constant scriptCode 

    Tests showing that CONST_SCRIPTCODE is applied only to non-segwit transactions
    @jl2012
    jl2012 committed May 4, 2018
    Copy the full SHA
    0f8719b View commit details
    Browse the repository at this point in the history

  3. Policy to reject extremely small transactions 

    A transaction with 1 segwit input and 1 P2WPHK output has non-witness size of 82 bytes. Anything smaller than this have unnecessary malloc overhead and are not relayed/mined.
    @jl2012
    jl2012 committed May 4, 2018
    Copy the full SHA
    7485488 View commit details
    Browse the repository at this point in the history

  4. qa: Pad scriptPubKeys to get minimum sized txs

    @jl2012
    MarcoFalke authored and jl2012 committed May 4, 2018
    Copy the full SHA
    364bae5 View commit details
    Browse the repository at this point in the history