Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 #11437

Merged
merged 2 commits into from Oct 5, 2017

Conversation

@fanquake
Copy link
Member

commented Oct 2, 2017

This updates the Windows build documentation with the workaround required to build using Ubuntu 17.04 on WSL, and makes it's explicit that building on Ubuntu 16.04 is broken, and not recommended.

This includes a commit from @donaloconnor in #11244, and is mostly the investigative work of @laanwj throughout #8732, #8653 and quite a few other issues.

I tested building on 14.04, 16.04.3 and 17.04 here and got the results we expect.


Built master at c22a53c on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.
windows

Upgraded WSL to 16.04.3, and tried building c22a53c using these instructions. The result is as expected.
ubuntu 16 04 3

Upgraded WSL to 17.04 and tried building 3255d63 using these instructions.
ubuntu 17 04

If someone else could also verify that builds are working on both 14.04 and 17.04 with these instructions, that would be great.

…ATH% paths that cause issues with the make system
Copy link
Member

left a comment

Concept ACK, looks good. Will try and test soon.

doc/build-windows.md Outdated
@@ -64,6 +65,13 @@ build process.

See also: [dependencies.md](dependencies.md).

If your building on Ubuntu 17.04, run these two commands, selecting the 'posix' variant for both,

This comment has been minimized.

Copy link
@meshcollider

meshcollider Oct 2, 2017

Member

your -> you're

@fanquake fanquake force-pushed the fanquake:windows-build-1704 branch Oct 2, 2017
@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 2, 2017

Thanks for doing this!
Hope someone that builds on windows can check this.

Copy link
Member

left a comment

Thanks! Tested ACK efd88160e39e5d55905eb6efa0c0f08029ef7a23 on artful.

doc/build-windows.md Outdated

Currently only building on Ubuntu Trusty 14.04 is supported.
Other versions are unsupported or known to be broken (e.g. Ubuntu Xenial 16.04).
Currently only building on Ubuntu Trusty 14.04 or Ubuntu Zesty 17.04 is supported.

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Oct 2, 2017

Member

Should say "17.04 and later"

doc/build-windows.md Outdated
@@ -64,6 +65,13 @@ build process.

See also: [dependencies.md](dependencies.md).

If you're building on Ubuntu 17.04, run these two commands, selecting the 'posix' variant for both,

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Oct 2, 2017

Member

"17.04 or later"

@fanquake fanquake force-pushed the fanquake:windows-build-1704 branch to 696ce46 Oct 2, 2017
@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 5, 2017

utACK 696ce46

@laanwj laanwj merged commit 696ce46 into bitcoin:master Oct 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Oct 5, 2017
…and Ubuntu 17.04

696ce46 [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 (fanquake)
4f890ba Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system (Donal OConnor)

Pull request description:

  This updates the Windows build documentation with the workaround required to build using Ubuntu 17.04 on WSL, and makes it's explicit that building on Ubuntu 16.04 is broken, and not recommended.

  This includes a commit from @donaloconnor in #11244, and is mostly the investigative work of @laanwj throughout #8732, #8653 and quite a few other issues.

  I tested building on 14.04, 16.04.3 and 17.04 [here](#11244 (comment)) and got the results we expect.

  ---

  Built master at c22a53c on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.
  ![windows](https://user-images.githubusercontent.com/863730/30195033-867f1f24-9489-11e7-932c-e87b8764a627.png)

  Upgraded WSL to 16.04.3, and tried building c22a53c using these instructions. The result is as expected.
  ![ubuntu 16 04 3](https://user-images.githubusercontent.com/863730/30235670-b9bf36bc-953d-11e7-8c1d-4debf7113032.png)

  Upgraded WSL to 17.04 and tried building 3255d63 using these instructions.
  ![ubuntu 17 04](https://user-images.githubusercontent.com/863730/30235669-b7473434-953d-11e7-8ea3-d05a319ae2d4.png)

  If someone else could also verify that builds are working on both 14.04 and 17.04 with these instructions, that would be great.

Tree-SHA512: 866f1003eb45d208d8ae849504f54fc2f27c32240129d2124ce5a2ee7167bcbf062d29f23b1745123f532ffd0253a8611e719b2a316d1331d3c3924f91e7775d
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Oct 5, 2017
…ATH% paths that cause issues with the make system

Github-Pull: bitcoin#11437
Rebased-From: 4f890ba
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Oct 9, 2017
@fanquake fanquake deleted the fanquake:windows-build-1704 branch Oct 15, 2017
laanwj added a commit that referenced this pull request Nov 13, 2017
7383d77 Updated instructions for Windows 10 Fall Creators Update. (Aaron Clauson)
e0fc4a7 Updated Windows build doc for WSL/Xenial workarounds. (Aaron Clauson)

Pull request description:

  An update to the Windows build document that provides workarounds for the broken 64 bit mingw32 cross compiler on WSL/Xenial.

  This update is an alternative to pull request #11437. While that pull request takes a valid approach by stating building on WSL should be avoided I think it is more useful to give Windows developers a workaround option.

  The instructions have been tested on:
  - Ubuntu 14.04 and 64 bit mingw32 tool chain
  - Ubuntu 16.04 and 64 bit mingw32 tool chain
  - Ubuntu 17.04 and 64 bit mingw32 tool chain
  - Windows Subsystem for Linux (Windows 10 OS Build 15063.608) and 32 bit mingw32 tool chain
  - Windows Subsystem for Linux (Windows 10 OS Build 15063.608) and 64 bit mingw32 tool chain

  Related items:
  - Serious incompatibility problems w/ newer mingw-64 on Ubuntu #8653
  - `-fstack-protector-all` triggers crashes in mingw-w64 5.3.1 #8732
  - Windows build appears broken on WSL (buntu okay) #10269
  - Compilation error for windows target #11437

Tree-SHA512: 7c937e37ed7120ae5dcf61aba50e5228a7ed6f729647c724b8f48e7cbbd81366c1a83a818618766a8fe0418425e05ba2eba2b14f2616621c58606585444f45fc
codablock added a commit to codablock/dash that referenced this pull request Sep 25, 2019
…ng WSL and Ubuntu 17.04

696ce46 [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 (fanquake)
4f890ba Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system (Donal OConnor)

Pull request description:

  This updates the Windows build documentation with the workaround required to build using Ubuntu 17.04 on WSL, and makes it's explicit that building on Ubuntu 16.04 is broken, and not recommended.

  This includes a commit from @donaloconnor in bitcoin#11244, and is mostly the investigative work of @laanwj throughout bitcoin#8732, bitcoin#8653 and quite a few other issues.

  I tested building on 14.04, 16.04.3 and 17.04 [here](bitcoin#11244 (comment)) and got the results we expect.

  ---

  Built master at bitcoin@c22a53c on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.
  ![windows](https://user-images.githubusercontent.com/863730/30195033-867f1f24-9489-11e7-932c-e87b8764a627.png)

  Upgraded WSL to 16.04.3, and tried building bitcoin@c22a53c using these instructions. The result is as expected.
  ![ubuntu 16 04 3](https://user-images.githubusercontent.com/863730/30235670-b9bf36bc-953d-11e7-8c1d-4debf7113032.png)

  Upgraded WSL to 17.04 and tried building bitcoin@3255d63 using these instructions.
  ![ubuntu 17 04](https://user-images.githubusercontent.com/863730/30235669-b7473434-953d-11e7-8ea3-d05a319ae2d4.png)

  If someone else could also verify that builds are working on both 14.04 and 17.04 with these instructions, that would be great.

Tree-SHA512: 866f1003eb45d208d8ae849504f54fc2f27c32240129d2124ce5a2ee7167bcbf062d29f23b1745123f532ffd0253a8611e719b2a316d1331d3c3924f91e7775d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.