Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Update named args documentation for importprivkey #11465

Merged
merged 1 commit into from Oct 9, 2017

Conversation

@dusty-wil
Copy link
Contributor

commented Oct 9, 2017

Addresses issue #11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey.

@promag

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

IMO remove 2nd commit.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

@promag It nicely proves that the documentation now matches the named args

@promag

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

The first commit does what the PR title states. No need to change the test to use named arguments. This is obviously my opinion!

@promag

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

No, the test does not prove that, to prove that we should assert the documentation string.

Again consider my comment above a nit.

@promag

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

There must be a test to assert argument order too :) (although that is probably in other tests).

@dusty-wil

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

@MarcoFalke @promag I can remove the second commit if you'd prefer! Is there a neat way to do that through github or do I need to re-commit with the changes?

@promag

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

For reference, this was missed in #8811 (9adb4e1).

@dusty-wil to remove the commit you must push again. But do not remove it now, wait for more comments.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

Fixes #11462. Updated documentation for importprivkey function to use the correct name for the first argument.
Also updates a call to importprivkey to use named args in functional test.
@dusty-wil dusty-wil force-pushed the dusty-wil:master branch to aa57590 Oct 9, 2017
@dusty-wil

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

@MarcoFalke ok, squashed!

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

utACK aa57590

@fanquake

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

utACK aa57590

1 similar comment
@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

utACK aa57590

@MarcoFalke MarcoFalke merged commit aa57590 into bitcoin:master Oct 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
MarcoFalke added a commit that referenced this pull request Oct 9, 2017
aa57590 Update importprivkey named args documentation (Dusty Williams)

Pull request description:

  Addresses issue #11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey.

Tree-SHA512: 64e14bf89c8c6eec9c37f6ec0c9fc0012fdb035d9ec32cd652110c75abaa922ec5c7523d6ec5098c8a7b42124159b5e330e070974eb79b8b92816f8d61074523
@dusty-wil

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Thanks for the opportunity to contribute!

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this pull request Oct 9, 2017
Fixes bitcoin#11462. Updated documentation for importprivkey function to use the correct name for the first argument.
Also updates a call to importprivkey to use named args in functional test.

Github-Pull: bitcoin#11465
Rebased-From: aa57590
codablock added a commit to codablock/dash that referenced this pull request Sep 25, 2019
…rivkey

aa57590 Update importprivkey named args documentation (Dusty Williams)

Pull request description:

  Addresses issue bitcoin#11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey.

Tree-SHA512: 64e14bf89c8c6eec9c37f6ec0c9fc0012fdb035d9ec32cd652110c75abaa922ec5c7523d6ec5098c8a7b42124159b5e330e070974eb79b8b92816f8d61074523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.