New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid slow transaction search with txindex enabled #11529

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
5 participants
@promag
Member

promag commented Oct 19, 2017

This is an alternative to #11507 where a slow search is not attempted (in any case) if txindex is enabled.

@promag

This comment has been minimized.

Show comment
Hide comment
@promag

promag Oct 19, 2017

Member

Ping @sipa after IRC discussion.

Member

promag commented Oct 19, 2017

Ping @sipa after IRC discussion.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Oct 19, 2017

Member

Is this preferable to #11507 which is an elegant one-line change?

Edit: Now this is a one-line change too

Member

laanwj commented Oct 19, 2017

Is this preferable to #11507 which is an elegant one-line change?

Edit: Now this is a one-line change too

Show outdated Hide outdated src/validation.cpp
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Oct 19, 2017

Member

utACK 7a5f930

Member

laanwj commented Oct 19, 2017

utACK 7a5f930

@achow101

This comment has been minimized.

Show comment
Hide comment
@achow101
Member

achow101 commented Oct 19, 2017

utACK 7a5f930

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Oct 19, 2017

Member

utACK

Member

sdaftuar commented Oct 19, 2017

utACK

@laanwj laanwj added the RPC/REST/ZMQ label Oct 19, 2017

@laanwj laanwj merged commit 7a5f930 into bitcoin:master Oct 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 19, 2017

Merge #11529: Avoid slow transaction search with txindex enabled
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa)

Pull request description:

  This is an alternative to #11507 where a slow search is not attempted (in any case) if `txindex` is enabled.

Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 11, 2017

codablock added a commit to codablock/dash that referenced this pull request Nov 19, 2017

Merge #11529: Avoid slow transaction search with txindex enabled
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa)

Pull request description:

  This is an alternative to #11507 where a slow search is not attempted (in any case) if `txindex` is enabled.

Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48

UdjinM6 added a commit to dashpay/dash that referenced this pull request Nov 22, 2017

Merge pull request #1729 from codablock/backport_bitcoin_11529
Backport bitcoin #11529: Avoid slow transaction search with txindex enabled (João Barbosa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment