/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Avoid slow transaction search with txindex enabled #11529

Merged
merged 1 commit into from Oct 19, 2017
+3 −0

Conversation

Reviewers

@MarcoFalke MarcoFalke

Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
5 participants
@promag @laanwj @achow101 @sdaftuar @MarcoFalke
@promag
Contributor

promag commented Oct 19, 2017

This is an alternative to #11507 where a slow search is not attempted (in any case) if txindex is enabled.
@promag
Contributor

promag commented Oct 19, 2017

Ping @sipa after IRC discussion.
@laanwj
Owner

laanwj commented Oct 19, 2017 •
Edited 1 time

Is this preferable to #11507 which is an elegant one-line change?

Edit: Now this is a one-line change too
src/validation.cpp
@@ -939,6 +939,8 @@ bool GetTransaction(const uint256 &hash, CTransactionRef &txOut, const Consensus
return error("%s: txid mismatch", __func__);
return true;
}
+
+ return false;
@MarcoFalke

MarcoFalke Oct 19, 2017

Member

Mind to add a tiny comment to explain why fAllowSlow can be ignored?

@promag

promag Oct 19, 2017

Contributor

Done.

@laanwj laanwj referenced this pull request Oct 19, 2017

Closed

[RPC] Don't do slow transaction lookup when txindex is enabled #11507

@laanwj
Owner

laanwj commented Oct 19, 2017

utACK 7a5f930
@achow101
Member

achow101 commented Oct 19, 2017

utACK 7a5f930
@sdaftuar
Member

sdaftuar commented Oct 19, 2017

utACK

@laanwj laanwj added the RPC/REST/ZMQ label Oct 19, 2017

@laanwj laanwj merged commit 7a5f930 into bitcoin:master Oct 19, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 19, 2017

@laanwj
Merge #11529: Avoid slow transaction search with txindex enabled 
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa)

Pull request description:

  This is an alternative to #11507 where a slow search is not attempted (in any case) if `txindex` is enabled.

Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 1E4AED62986CD25D Learn about signing commits
ff92fbf

@fanquake fanquake referenced this pull request Oct 21, 2017

Closed

getrawtransaction delay too long on non-existent txid #11506

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 11, 2017

@promag @luke-jr
Avoid slow transaction search with txindex enabled 
Github-Pull: #11529
Rebased-From: 7a5f930
5f80fcb

@UdjinM6 UdjinM6 referenced this pull request in dashpay/dash Nov 18, 2017

Closed

Avoid running the fAllowSlow code path in case the txindex is available #1727

codablock added a commit to codablock/dash that referenced this pull request Nov 19, 2017

@laanwj @codablock
Merge #11529: Avoid slow transaction search with txindex enabled 
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa)

Pull request description:

  This is an alternative to #11507 where a slow search is not attempted (in any case) if `txindex` is enabled.

Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48
371feda

UdjinM6 added a commit to dashpay/dash that referenced this pull request Nov 22, 2017

@UdjinM6
Merge pull request #1729 from codablock/backport_bitcoin_11529 
Backport bitcoin #11529: Avoid slow transaction search with txindex enabled (João Barbosa)
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3e86c41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment