/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rpc: Make `logging` RPC public #11626

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
7 participants
@laanwj @fanquake @promag @achow101 @jnewbery @TheBlueMatt @MarcoFalke
@laanwj
Owner

laanwj commented Nov 7, 2017

This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to control category. This makes it documented in help.
@laanwj
rpc: Make logging RPC public 
This started out as a developer hack but now it's useful
enough for general use. Unhide the call by moving it to `control` category.
This makes it documented in `help`.
cabff75

@laanwj laanwj added the RPC/REST/ZMQ label Nov 7, 2017

@fanquake
Member

fanquake commented Nov 7, 2017

utACK cabff75

IRC discussion - https://botbot.me/freenode/bitcoin-core-dev/2017-11-07/?msg=93216104&page=1
@promag
Contributor

promag commented Nov 7, 2017

utACK cabff75.
@achow101
Member

achow101 commented Nov 7, 2017

utACK cabff75
@jnewbery
Member

jnewbery commented Nov 7, 2017 •
Edited 1 time

ACK cabff75. I have no objection to making this unhidden.

Could also be done as part of this PR, but not strictly necessary: the help text could be cleaned up. For example "libevent logging is configured on startup and cannot be modified by this RPC during runtime." is incorrect after 7fd50c3 (libevent logging can be updated for most versions of libevent). A few more newlines in the help text wouldn't hurt either.
@TheBlueMatt
Contributor

TheBlueMatt commented Nov 7, 2017

Concept ACK

@MarcoFalke MarcoFalke merged commit cabff75 into bitcoin:master Nov 7, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 7, 2017

@MarcoFalke
Merge #11626: rpc: Make `logging` RPC public 
cabff75 rpc: Make logging RPC public (Wladimir J. van der Laan)

Pull request description:

  This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`.

Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4
This commit was signed with a verified signature.
@MarcoFalke MarcoFalke
GPG key ID: D2EA4850E7528B25 Learn about signing commits
998c304

@fanquake fanquake referenced this pull request Nov 8, 2017

Open

Cleanup `logging` RPC help text #11631

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 11, 2017

@laanwj @luke-jr
rpc: Make logging RPC public 
This started out as a developer hack but now it's useful
enough for general use. Unhide the call by moving it to `control` category.
This makes it documented in `help`.

Github-Pull: #11626
Rebased-From: cabff75
31ba1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment