Skip to content

Trim trailing whitespace in src/*.{cpp,h} #1170

Closed
wants to merge 1 commit into from

6 participants

@jgarzik
Bitcoin member
jgarzik commented Apr 30, 2012

This commit changes no code, and makes no other cleanups than removing the trailing whitespace from source code and comment lines.

Script used: https://gist.github.com/2561322

@laanwj
Bitcoin member
laanwj commented Apr 30, 2012

I'll never understand this war on spaces. IMO this just breaks other patches for reason at all.

@jgarzik
Bitcoin member
jgarzik commented Apr 30, 2012

It is a very minor change, yes, but it pops up again and again in pull requests for various projects. Sometimes editors automatically trim this stuff, which may generate larger patches (with changes in unexpected areas) down the road.

Others will submit this stuff, as was already done in #1136, so might as well make our stuff uniform all in one go.

@Diapolo
Diapolo commented Apr 30, 2012

Great big and never-ending ACK ;).

@rebroad
rebroad commented May 2, 2012

Well done. Does this mean I'll have more free disk space after applying this?

@gmaxwell
gmaxwell commented May 5, 2012

I think we should pull this in 0.7.0 after pulling most of the other outstanding 0.7.0 pulls that this would break.

@Diapolo
Diapolo commented May 6, 2012

I think this should be rebased once more (if needed) and then get merged. Why should this even break pulls, it removes not a single line only spaces?

@jgarzik
Bitcoin member
jgarzik commented May 6, 2012

It is scripted, thus may be regenerated from scratch at any time.

@sipa
Bitcoin member
sipa commented May 6, 2012

ACK for applying at the end of 0.7.0's merge window.

@jgarzik
Bitcoin member
jgarzik commented Jun 27, 2012

Closing. Will run script to do this immediately prior to 0.7rc1 release...

@jgarzik jgarzik closed this Jun 27, 2012
@Diapolo
Diapolo commented Jun 27, 2012

I hope so ^^.

@jgarzik jgarzik deleted the jgarzik:ws branch Aug 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.