Multiselect in coincontrol treewidget and display selected count

[elbandi]

This patch allow multiple out selection in coincontrol dialog.
Only for changing the checked state, locking need single select.

usecase: someone gets lost of payments from zpool/miningrigrentals/nicehash/etc, its easy to select inputs for sending (no need to click many times in intems or space-down-space-down-space-down... by keyboard)

[promag]

Care to upload a screenshot with the diff?

[promag]

Remove space after (.

[promag]

How about:

int count = selected.size();
ui->labelSelected->setVisible(count > 0);
ui->labelSelected->setText(tr("(%1 selected)").arg(count));

[elbandi]

It hides the "(X selected)" label if no selection. like locked count

[promag]

ui->labelSelected->setVisible(count > 0); should hide when there's no selection.

[promag]

Incorrect?

[elbandi]

???,
placeholder string, as in labelLocked

[promag]

Don't know why that is there too, and I think there is no special reason. I guess it's ok since it is consistent with others.

[promag]

for (QTreeWidgetItem* item : selectedItems()) {

[promag]

Comment should be "press spacebar -> toggle checkbox"?

[elbandi]

new commit pushed

[jonasschnelli]

Tested a bit.
The multiselection works well.

I got confused by the selection count indicator label.
It's confusing because you have the first button "(un)select all" where the new "(1) selected" has a different context for "selected".

Maybe remove the label (just add the multiselection possibility) or use a different help text for the new label... though I don't think it's necessary to have a such label (rarely saw this in multiselection use-cases).

[elbandi]

Rename the button to "(un)check all", eventually thats the right function.

[laanwj]

It's confusing because you have the first button "(un)select all" where the new "(1) selected" has a different context for "selected".

I have the same opinion here; the coin selection is already inherently multi-select, as multiple outputs can be checked. So adding another layer of multi-selection on top is confusing. It's no longer clear whether selection refers to "toggled checkbox" or "selected row".

[luke-jr]

I agree this is confusing, yet also see the validity of the use case.

Maybe @jonasschnelli 's idea + renaming the button to "(Un)check all" would be sufficient.

[jonasschnelli]

I think we should remove the new label. Just allow the spacebar toggling. Seems much more clear to me then confusing with "selection" (multiple contexts of selection)

[laanwj]

Last post by the author was some time last year. Going to add "Up for grabs" label and closing.

[elbandi]

Sorry, i didnt know, what is the latest consensus about the text?
i can change the code, just someone say "lets be this and that"

[luke-jr]

@elbandi I guess do what @jonasschnelli suggested. When you're ready, ping someone to reopen the PR before you push the new version.