Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[depends] zeromq 4.2.3 #11986
With all the dependencies that are linked in; as I understand zeromq isn't turned on used by default, however it is linked by default.
My main concern is that in dependencies there is some reflective code that has been designed to compromise Bitcoin Core. Is this a realistic concern?; how much dew-diligence do we need to audit the history of linked libs to make sure there isn't any nastyness?
AFAIK even when zmq has not been enabled via
So... yeah. Unsure.
The issue here is that ZeroMQ started using pthread_set_name_np to name their background threads, see zeromq/libzmq#2367.
pthread_set_name_np was introduced in GLIB 2.12, and the max GLIB version allowed by symbol-check.py is 2.11.
We are currently using pthread_set_name_np for thread naming in util.cpp. Might be time to consider increasing the max allowed GLIB version in symbol-check.py ?
This is likely going to cause complaints, because it means the binary won't run on some distributions anymore. Not sure what the minimum glibc in commonly used (stable) distributions is, though.
We could open a separate issue for that.
Mar 6, 2018
1 check passed
added a commit
this pull request
Mar 6, 2018
referenced this pull request
Jun 30, 2018
@theuni fair enough. I'm doing a PR to backport a zmq upstream but unmerged patch zeromq/libzmq@58d1339
More context: #11844 (comment)
I'm aware of #13578 so i also backported it in case that gets merged first https://github.com/greenaddress/bitcoin/commits/zmq-upgrade-mruddy-patched