Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RPC: Add child transactions to getrawmempool verbose output #12479
Currently the only way to find child transactions is to use
This change allows direct lookup of children.
This is cool. I'd thought about adding a similar concept to getblocktemplate (or some sort of package number or something).
Have you given any thought to performance / done any benchmarking? I'm particularly thinking of what happens when the mempool is in the hundreds of megs as it was not too long ago.
doc/developer-notes.md regarding style for new code.
I have updated commits from your comments.
It is correct that this just adds a map lookup per transactions, but I went ahead and tested performance as well. This seems to add about 3% in execution time in my particular test.
The details are that I hacked together a test to generate a mempool of 18k transactions with long chains of unconfirmed transactions that excercise child/parent relations for
@dcousens I am not sure we want to add the
@conscott I think that is fine, I guess it depends on the verbosity required for your application. The few places I can see this being useful, I would appreciate the