Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server #12490

Merged
merged 3 commits into from Sep 7, 2018

Conversation

Projects
None yet
6 participants
@jnewbery
Copy link
Member

commented Feb 20, 2018

The following rpc features were deprecated in V0.17:

  • validateaddress returning wallet information about an address
  • signrawtransaction

This PR fully removes those features. It can be merged once V0.17 has been branched from master.

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2018

open-closing this PR so the branch is available to everyone. This + #10762 should allow server to be built without any dependencies on wallet.

Will re-open once V0.17 has been branched.

Edit: #10762 has been merged. I've now rebased this on master.

@jnewbery jnewbery closed this Feb 20, 2018

@jnewbery jnewbery changed the title Remove deprecated wallet rpc methods from server Remove deprecated wallet rpc features from bitcoin_server Feb 20, 2018

@bitcoin bitcoin deleted a comment from dmoney0546 Feb 20, 2018

@jnewbery jnewbery reopened this Apr 3, 2018

@jnewbery jnewbery force-pushed the jnewbery:remove_deprecated_rpcs branch Apr 3, 2018

@jnewbery jnewbery closed this Apr 3, 2018

@jnewbery jnewbery reopened this Aug 6, 2018

@jnewbery jnewbery force-pushed the jnewbery:remove_deprecated_rpcs branch Aug 6, 2018

@jnewbery jnewbery changed the title Remove deprecated wallet rpc features from bitcoin_server [DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server Aug 6, 2018

@jnewbery jnewbery changed the title [DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server [DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server Aug 6, 2018

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2018

rebased

@jnewbery jnewbery force-pushed the jnewbery:remove_deprecated_rpcs branch 2 times, most recently from f43f11c Aug 6, 2018

@MarcoFalke MarcoFalke added the Wallet label Aug 6, 2018

@DrahtBot DrahtBot referenced this pull request Aug 6, 2018

Closed

[wallet] Kill accounts #13825

@MarcoFalke
Copy link
Member

left a comment

utACK 1158febc93707910d783be863aa05c8f6cfedb2f

src/rpc/misc.cpp Outdated
std::string currentAddress = EncodeDestination(dest);
ret.pushKV("address", currentAddress);
CScript scriptPubKey = GetScriptForDestination(dest);
ret.pushKV("scriptPubKey", HexStr(scriptPubKey.begin(), scriptPubKey.end()));;

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Aug 6, 2018

Member

nit: No need for double semicolon?

This comment has been minimized.

Copy link
@jnewbery

jnewbery Aug 6, 2018

Author Member

thanks. Fixed

@jnewbery jnewbery force-pushed the jnewbery:remove_deprecated_rpcs branch Aug 6, 2018

@jnewbery jnewbery changed the title [DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server Aug 14, 2018

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2018

V0.17 has been branched. This is ready for review/merge

jnewbery added some commits Feb 20, 2018

[RPC] Remove warning about wallet addresses in createmultisig()
createmultisig() was updated in V0.16 to not use the wallet. Warning
text was included to warn the user. Remove that now.

@jnewbery jnewbery force-pushed the jnewbery:remove_deprecated_rpcs branch to f7e9e70 Aug 27, 2018

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

rebased

@DrahtBot DrahtBot removed the Needs rebase label Aug 27, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

re-utACK f7e9e70

@promag

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

utACK f7e9e70.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Sep 7, 2018

Merge bitcoin#12490: [Wallet] [RPC] Remove deprecated wallet rpc feat…
…ures from bitcoin_server

f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery)
90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery)
df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery)

Pull request description:

  The following rpc features were deprecated in V0.17:

  - `validateaddress` returning wallet information about an address
  - `signrawtransaction`

  This PR fully removes those features. It can be merged once V0.17 has been branched from master.

Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6

@MarcoFalke MarcoFalke merged commit f7e9e70 into bitcoin:master Sep 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ptyx11

This comment has been minimized.

Copy link

commented Sep 11, 2018

What was the reasoning behind this? It seems unnecessary.

@achow101

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

@ptyx11 This is part of the separation of the wallet from the node. Those RPCs were node RPCs which involved wallet things, so they needed to be removed. They have been deprecated for at least one major version with replacement RPCs already available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.