Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server #12490

Merged
merged 3 commits into from Sep 7, 2018

Conversation

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Feb 20, 2018

The following rpc features were deprecated in V0.17:

  • validateaddress returning wallet information about an address
  • signrawtransaction

This PR fully removes those features. It can be merged once V0.17 has been branched from master.

@jnewbery
Copy link
Member Author

@jnewbery jnewbery commented Feb 20, 2018

open-closing this PR so the branch is available to everyone. This + #10762 should allow server to be built without any dependencies on wallet.

Will re-open once V0.17 has been branched.

Edit: #10762 has been merged. I've now rebased this on master.

@jnewbery jnewbery closed this Feb 20, 2018
@jnewbery jnewbery changed the title Remove deprecated wallet rpc methods from server Remove deprecated wallet rpc features from bitcoin_server Feb 20, 2018
@bitcoin bitcoin deleted a comment from dmoney0546 Feb 20, 2018
@jnewbery jnewbery reopened this Apr 3, 2018
@jnewbery jnewbery force-pushed the remove_deprecated_rpcs branch from dec8bd4 to 6f21090 Apr 3, 2018
@jnewbery jnewbery closed this Apr 3, 2018
@jnewbery jnewbery reopened this Aug 6, 2018
@jnewbery jnewbery force-pushed the remove_deprecated_rpcs branch from 6f21090 to 47aa910 Aug 6, 2018
@jnewbery jnewbery changed the title Remove deprecated wallet rpc features from bitcoin_server [DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server Aug 6, 2018
@jnewbery jnewbery changed the title [DO NOT MERGE UNTI Lv0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server [DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server Aug 6, 2018
@jnewbery
Copy link
Member Author

@jnewbery jnewbery commented Aug 6, 2018

rebased

@jnewbery jnewbery force-pushed the remove_deprecated_rpcs branch 2 times, most recently from f43f11c to 1158feb Aug 6, 2018
@DrahtBot DrahtBot mentioned this pull request Aug 6, 2018
Copy link
Member

@MarcoFalke MarcoFalke left a comment

utACK 1158febc93707910d783be863aa05c8f6cfedb2f

src/rpc/misc.cpp Outdated
std::string currentAddress = EncodeDestination(dest);
ret.pushKV("address", currentAddress);
CScript scriptPubKey = GetScriptForDestination(dest);
ret.pushKV("scriptPubKey", HexStr(scriptPubKey.begin(), scriptPubKey.end()));;
Copy link
Member

@MarcoFalke MarcoFalke Aug 6, 2018

nit: No need for double semicolon?

Copy link
Member Author

@jnewbery jnewbery Aug 6, 2018

thanks. Fixed

@jnewbery jnewbery force-pushed the remove_deprecated_rpcs branch from 1158feb to 25bf889 Aug 6, 2018
@jnewbery jnewbery changed the title [DO NOT MERGE UNTIL v0.18] [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server Aug 14, 2018
@jnewbery
Copy link
Member Author

@jnewbery jnewbery commented Aug 14, 2018

V0.17 has been branched. This is ready for review/merge

jnewbery added 3 commits Aug 27, 2018
createmultisig() was updated in V0.16 to not use the wallet. Warning
text was included to warn the user. Remove that now.
@jnewbery jnewbery force-pushed the remove_deprecated_rpcs branch from 25bf889 to f7e9e70 Aug 27, 2018
@jnewbery
Copy link
Member Author

@jnewbery jnewbery commented Aug 27, 2018

rebased

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Aug 29, 2018

re-utACK f7e9e70

@promag
Copy link
Member

@promag promag commented Sep 7, 2018

utACK f7e9e70.

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Sep 7, 2018
…ures from bitcoin_server

f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery)
90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery)
df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery)

Pull request description:

  The following rpc features were deprecated in V0.17:

  - `validateaddress` returning wallet information about an address
  - `signrawtransaction`

  This PR fully removes those features. It can be merged once V0.17 has been branched from master.

Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6
@MarcoFalke MarcoFalke merged commit f7e9e70 into bitcoin:master Sep 7, 2018
2 checks passed
@ptyx11
Copy link

@ptyx11 ptyx11 commented Sep 11, 2018

What was the reasoning behind this? It seems unnecessary.

@achow101
Copy link
Member

@achow101 achow101 commented Sep 11, 2018

@ptyx11 This is part of the separation of the wallet from the node. Those RPCs were node RPCs which involved wallet things, so they needed to be removed. They have been deprecated for at least one major version with replacement RPCs already available.

deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Mar 20, 2020
Summary:
Looks like this was partially done in D3978.

Partial backport of Core [[bitcoin/bitcoin#12490 | PR12490]]

Test Plan:
  cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
  ninja
  ninja check
  ninja check-functional
  ./bitcoind
  ./bitcoin-cli getnewaddress
Verify rpc fails because there is no wallet.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5520
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue May 19, 2020
Summary:
Looks like this was partially done in D3978.

Partial backport of Core [[bitcoin/bitcoin#12490 | PR12490]]

Test Plan:
  cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
  ninja
  ninja check
  ninja check-functional
  ./bitcoind
  ./bitcoin-cli getnewaddress
Verify rpc fails because there is no wallet.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5520
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 30, 2021
…ures from bitcoin_server

f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery)
90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery)
df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery)

Pull request description:

  The following rpc features were deprecated in V0.17:

  - `validateaddress` returning wallet information about an address
  - `signrawtransaction`

  This PR fully removes those features. It can be merged once V0.17 has been branched from master.

Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 30, 2021
…ures from bitcoin_server

f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery)
90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery)
df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery)

Pull request description:

  The following rpc features were deprecated in V0.17:

  - `validateaddress` returning wallet information about an address
  - `signrawtransaction`

  This PR fully removes those features. It can be merged once V0.17 has been branched from master.

Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6
PastaPastaPasta pushed a commit to dashpay/dash that referenced this issue Sep 1, 2021
…ures from bitcoin_server (#4380)

f7e9e70 [rpc] Remove deprecated sigrawtransaction rpc method. (John Newbery)
90c8340 [RPC] Remove warning about wallet addresses in createmultisig() (John Newbery)
df905e3 [rpc] Remove deprecated validateaddress usage. (John Newbery)

Pull request description:

  The following rpc features were deprecated in V0.17:

  - `validateaddress` returning wallet information about an address
  - `signrawtransaction`

  This PR fully removes those features. It can be merged once V0.17 has been branched from master.

Tree-SHA512: 28293d218cf7e348632081e362f8775f243d091f49aed54c354f017d4a12ae92b87b99f81ee592a1bbf4aebd5d8cd5119278141edde7a0399ff82917ed68b9f6

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants