Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] fix version typo in getpeerinfo RPC call help #12556

Merged
merged 1 commit into from Feb 27, 2018

Conversation

@tamasblummer
Copy link
Contributor

commented Feb 27, 2018

RPC getpeeerinfo help output uses non-existent protocol version 7001. Changed to 70001.

@conscott

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

Tested d16bfaa ACK

@laanwj laanwj added this to the 0.16.1 milestone Feb 27, 2018
@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 27, 2018

Yes, that was probably the intention here. utACK.

@laanwj laanwj merged commit d16bfaa into bitcoin:master Feb 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Feb 27, 2018
d16bfaa fix version typo (Tamas Blummer)

Pull request description:

  RPC getpeeerinfo help output uses non-existent protocol version 7001. Changed to 70001.

Tree-SHA512: aea634d739b51bf26e3f871e8bf2bf812eb62a5d87008ead3ed27ec8bd9b753ad0a958eb21f580e505d7f2b36d60e5d9901dc8e0d25f34b7ef9533fddc898844
fanquake added a commit to fanquake/bitcoin that referenced this pull request Mar 7, 2018
GitHub-Pull: bitcoin#12556
Rebased-From: d16bfaa
MarcoFalke added a commit that referenced this pull request Mar 7, 2018
…ll help

e730b82 fix version typo (Tamas Blummer)

Pull request description:

  GitHub-Pull: #12556
  Rebased-From: d16bfaa

Tree-SHA512: b6626fabdd5f493016334ada0182565c7f834a22dc08dc846c71a190e61193dd4e28754e67b20086d9afeab9a58e38c3621c614eadf368b2d35b9c08a843356a
HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Mar 16, 2018
GitHub-Pull: bitcoin#12556
Rebased-From: d16bfaa

Conflicts:
	src/rpc/net.cpp
@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 12, 2018

Removed "Needs Backport" as this was backported in #12637.

Mengerian pushed a commit to Mengerian/bitcoin-abc that referenced this pull request Aug 6, 2019
Summary:
d16bfaa fix version typo (Tamas Blummer)

Pull request description:

  RPC getpeeerinfo help output uses non-existent protocol version 7001. Changed to 70001.

Tree-SHA512: aea634d739b51bf26e3f871e8bf2bf812eb62a5d87008ead3ed27ec8bd9b753ad0a958eb21f580e505d7f2b36d60e5d9901dc8e0d25f34b7ef9533fddc898844

Backport of Core PR12556
bitcoin/bitcoin#12556

Test Plan:
  make check
  ./bitcoind
  ./bitcoin-cli help getpeerinfo

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.