Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set modal overlay hide button as default #12616

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@promag
Copy link
Member

promag commented Mar 6, 2018

Without this change the only way to close the modal overlay is to click the hide button. Setting the button to default allows to activate it with the ENTER key.

Before:
screen shot 2018-03-06 at 15 14 23

After:
screen shot 2018-03-06 at 15 12 41

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Mar 6, 2018

Concept ACK

@randolf

randolf approved these changes Mar 6, 2018

@randolf

This comment has been minimized.

Copy link
Contributor

randolf commented Mar 6, 2018

ACK because improving keyboard support in the GUI is important.

@fanquake fanquake added the GUI label Mar 6, 2018

@laanwj laanwj merged commit cfdd895 into bitcoin:master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 6, 2018

Merge #12616: Set modal overlay hide button as default
cfdd895 qt: Set modal overlay hide button as default (João Barbosa)

Pull request description:

  Without this change the only way to close the modal overlay is to click the hide button. Setting the button to default allows to activate it with the ENTER key.

  Before:
  <img width="849" alt="screen shot 2018-03-06 at 15 14 23" src="https://user-images.githubusercontent.com/3534524/37040276-58af9ce0-2151-11e8-8c55-50acdea669d9.png">

  After:
  <img width="848" alt="screen shot 2018-03-06 at 15 12 41" src="https://user-images.githubusercontent.com/3534524/37040294-650d1c9c-2151-11e8-8245-2da250a71b3d.png">

Tree-SHA512: a93ef440a507843ed7870fd07a693af93dd97c8fce2fb6824c69a227b5dee258f340bf1ae344da32a9dd6e6cb2330f72db9dac9635bbd34184c3e7f8476a472e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.