RPC: Support addnode onetry without making the connection priviliged

[luke-jr]

The behaviour of addnode onetry changed without notice. This restores the ability to at least get the original behaviour.

Needed for properly testing DoS rules.

[maflcko]

rpc_net.py fails

[meshcollider]

Concept ACK

[TheBlueMatt]

This breaks our outbound-connection-counting logic in the aut-connect loop as it uses the manual connection flag to figure out how many other connections to make.

[jnewbery]

Why no PR description? What's the use case for this?

[luke-jr]

Added a PR description, and kicked Travis.

[sipa]

Can you address @TheBlueMatt's comment here: #12674 (comment) ?

[luke-jr]

@TheBlueMatt @sipa I don't consider that broken. A non-privileged connection should be treated the same as any other normal outgoing connection.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• Remove g_rpc_node global #18740 (Remove g_rpc_node global by ryanofsky)
• test: checks that bitcoin-cli autocomplete is in sync #18606 (test: checks that bitcoin-cli autocomplete is in sync by pierreN)
• rpc: remove deprecated CRPCCommand constructor #18531 (rpc: Assert that RPCArg names are equal to CRPCCommand ones by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[luke-jr]

Rebased

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

[luke-jr]

Superceding with #20551