Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Support addnode onetry without making the connection priviliged #12674

Closed
wants to merge 1 commit into from

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Mar 12, 2018

The behaviour of addnode onetry changed without notice. This restores the ability to at least get the original behaviour.

Needed for properly testing DoS rules.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Mar 12, 2018

rpc_net.py fails

src/rpc/net.cpp Outdated Show resolved Hide resolved
src/rpc/net.cpp Outdated Show resolved Hide resolved
src/rpc/net.cpp Show resolved Hide resolved
@meshcollider
Copy link
Member

@meshcollider meshcollider commented Mar 13, 2018

Concept ACK

@luke-jr luke-jr force-pushed the luke-jr:rpc_onetry_nonpriv branch to 0670e4f Mar 13, 2018
@TheBlueMatt
Copy link
Contributor

@TheBlueMatt TheBlueMatt commented Mar 28, 2018

This breaks our outbound-connection-counting logic in the aut-connect loop as it uses the manual connection flag to figure out how many other connections to make.

Copy link
Member

@jnewbery jnewbery left a comment

Why no PR description? What's the use case for this?

src/rpc/net.cpp Outdated Show resolved Hide resolved
@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Mar 31, 2018

Added a PR description, and kicked Travis.

@DrahtBot DrahtBot closed this Jul 21, 2018
@DrahtBot DrahtBot reopened this Jul 21, 2018
@sipa
Copy link
Member

@sipa sipa commented Jul 21, 2018

Can you address @TheBlueMatt's comment here: #12674 (comment) ?

@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Jul 21, 2018

@TheBlueMatt @sipa I don't consider that broken. A non-privileged connection should be treated the same as any other normal outgoing connection.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Oct 20, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #18740 (Remove g_rpc_node global by ryanofsky)
  • #18606 (test: checks that bitcoin-cli autocomplete is in sync by pierreN)
  • #18531 (rpc: Assert that RPCArg names are equal to CRPCCommand ones by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Feb 12, 2019

Rebased

@luke-jr luke-jr force-pushed the luke-jr:rpc_onetry_nonpriv branch from 0670e4f to 73891da Feb 12, 2019
@DrahtBot DrahtBot removed the Needs rebase label Feb 12, 2019
src/rpc/net.cpp Outdated Show resolved Hide resolved
@bitcoin bitcoin deleted a comment from DrahtBot Feb 12, 2019
@luke-jr luke-jr force-pushed the luke-jr:rpc_onetry_nonpriv branch from 73891da to cd961a4 May 2, 2019
@DrahtBot DrahtBot removed the Needs rebase label May 2, 2019
src/rpc/net.cpp Show resolved Hide resolved
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented May 21, 2020

🐙 This pull request conflicts with the target branch and needs rebase.

@luke-jr luke-jr closed this Dec 2, 2020
@luke-jr
Copy link
Member Author

@luke-jr luke-jr commented Dec 2, 2020

Superceding with #20551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.