RPC: Support addnode onetry without making the connection priviliged #12674
Conversation
rpc_net.py fails |
src/rpc/net.cpp
Outdated
Show resolved
Hide resolved
src/rpc/net.cpp
Outdated
Show resolved
Hide resolved
Concept ACK |
This breaks our outbound-connection-counting logic in the aut-connect loop as it uses the manual connection flag to figure out how many other connections to make. |
Why no PR description? What's the use case for this? |
Added a PR description, and kicked Travis. |
Can you address @TheBlueMatt's comment here: #12674 (comment) ? |
@TheBlueMatt @sipa I don't consider that broken. A non-privileged connection should be treated the same as any other normal outgoing connection. |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Rebased |
|
Superceding with #20551 |
The behaviour of addnode onetry changed without notice. This restores the ability to at least get the original behaviour.
Needed for properly testing DoS rules.