New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC: Support addnode onetry without making the connection priviliged #12674
Conversation
rpc_net.py fails |
Concept ACK |
c21d55a
to
0670e4f
Compare
This breaks our outbound-connection-counting logic in the aut-connect loop as it uses the manual connection flag to figure out how many other connections to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no PR description? What's the use case for this?
Added a PR description, and kicked Travis. |
Can you address @TheBlueMatt's comment here: #12674 (comment) ? |
@TheBlueMatt @sipa I don't consider that broken. A non-privileged connection should be treated the same as any other normal outgoing connection. |
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Rebased |
0670e4f
to
73891da
Compare
73891da
to
cd961a4
Compare
cd961a4
to
7711302
Compare
🐙 This pull request conflicts with the target branch and needs rebase. |
Superceding with #20551 |
The behaviour of addnode onetry changed without notice. This restores the ability to at least get the original behaviour.
Needed for properly testing DoS rules.