Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add P2P, Network, and Qt categories to the desktop icon #12854

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
4 participants
@luke-jr
Copy link
Member

luke-jr commented Apr 2, 2018

No description provided.

@@ -10,5 +10,5 @@ Terminal=false
Type=Application
Icon=bitcoin128
MimeType=x-scheme-handler/bitcoin;
Categories=Office;Finance;
Categories=Office;Finance;P2P;Network;Qt;

This comment has been minimized.

@laanwj

laanwj Apr 2, 2018

Member

I don 't think Qt is a useful category. It's like adding C++. Not relevant to classifying the application.
Agree with adding P2P or Network though I'd say one of them is enough (but adding both is fine with me...).

This comment has been minimized.

@luke-jr

luke-jr Apr 2, 2018

Author Member

The Qt category is defined as "Application based on Qt libraries", which certainly applies to bitcoin-qt.

https://specifications.freedesktop.org/menu-spec/latest/apas02.html

This comment has been minimized.

@laanwj

laanwj Apr 3, 2018

Member

Huh, okay.
Well if it's part of the standard then ok...

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Apr 3, 2018

utACK b63f23c

@Sjors

This comment has been minimized.

Copy link
Member

Sjors commented Apr 3, 2018

Is Debian the only distro supporting this standard?

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Apr 8, 2018

freedesktop standards in principle apply to all distributions and window managers.
So it would make sense to move it from contrib/debian to a place where make install can install it (not in thie PR though).

@laanwj laanwj merged commit b63f23c into bitcoin:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 10, 2018

Merge #12854: Add P2P, Network, and Qt categories to the desktop icon
b63f23c Add P2P, Network, and Qt categories to the desktop icon (Luke Dashjr)

Pull request description:

Tree-SHA512: 10526bfb4b559ce43b28c6c82fa615cd167162e5c487025ade51fb6b67389a65d8b43138228ced49d6d6cdc8ac87654a7b76673e92e7b43b5a09c81642d59145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.