Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add P2P, Network, and Qt categories to the desktop icon #12854

Merged
merged 1 commit into from Apr 10, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

@@ -10,5 +10,5 @@ Terminal=false
Type=Application
Icon=bitcoin128
MimeType=x-scheme-handler/bitcoin;
Categories=Office;Finance;
Categories=Office;Finance;P2P;Network;Qt;

This comment has been minimized.

Copy link
@laanwj

laanwj Apr 2, 2018

Member

I don 't think Qt is a useful category. It's like adding C++. Not relevant to classifying the application.
Agree with adding P2P or Network though I'd say one of them is enough (but adding both is fine with me...).

This comment has been minimized.

Copy link
@luke-jr

luke-jr Apr 2, 2018

Author Member

The Qt category is defined as "Application based on Qt libraries", which certainly applies to bitcoin-qt.

https://specifications.freedesktop.org/menu-spec/latest/apas02.html

This comment has been minimized.

Copy link
@laanwj

laanwj Apr 3, 2018

Member

Huh, okay.
Well if it's part of the standard then ok...

StartupWMClass=Bitcoin-qt
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.