Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
net: Add option `-enablebip61` to configure sending of BIP61 notifications #13134
This commit adds a boolean option
On the other hand, reject messages can be useful while developing client software (I found them indispensable while creating bitcoin-submittx), as well as for our own test cases, so whatever the default becomes on the long run, IMO the functionality should be retained as option. But that's a discussion for later, for now it's simply a node operator decision.
Also adds a RPC test that checks the functionality.
1 similar comment
jnewbery left a comment
Tested ACK 39d4d10bc961ae939b6bdabfd030140012c8b395
My only micro-nit has been covered by @MarcoFalke
A couple of general points/questions:
Possible enhancements for future PRs:
As you might have guessed from the variable name I used that name at first, but thought this name was more direct/clear. But I'm ok with changing it to that.
One of the reasons for switching it around was that
I think that's an orthogonal concern. One might want their node to be silent but still listen to other's reject messages.
Right - and that's not even with changed
If it gets to that