Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 #13154

Merged
merged 1 commit into from May 3, 2018

Conversation

ryanofsky
Copy link
Contributor

No description provided.

@fanquake fanquake added the Docs label May 2, 2018
@fanquake
Copy link
Member

fanquake commented May 2, 2018

utACK 21f5680

@promag
Copy link
Member

promag commented May 2, 2018

utACK 21f5680.

@laanwj
Copy link
Member

laanwj commented May 2, 2018

Gah, apparently the script in 50b6533 didn't cover these.

    -BEGIN VERIFY SCRIPT-
    sed -i 's/SetBestChain/ChainStateFlushed/g' src/validationinterface.h src/validationinterface.cpp src/wallet/wallet.h src/wallet/wallet.cpp src/validation.cpp src/index/txindex.h src/index/txindex.cpp
    -END VERIFY SCRIPT-

@maflcko
Copy link
Member

maflcko commented May 2, 2018

Yeah, imo git grep -l foo ./src/ is less fragile than hardcoding all the file names.

@practicalswift
Copy link
Contributor

utACK 21f5680

@laanwj
Copy link
Member

laanwj commented May 3, 2018

Yeah, imo git grep -l foo ./src/ is less fragile than hardcoding all the file names.

Yes, though, please use git ls-files in that case otherwise it'll search/replace in executables and IDE metadata files unrelated to git too...

@laanwj laanwj merged commit 21f5680 into bitcoin:master May 3, 2018
laanwj added a commit that referenced this pull request May 3, 2018
…fter #13106

21f5680 Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 (Russell Yanofsky)

Pull request description:

Tree-SHA512: 373896dd73c3ba202739433b22320a4b7ea6dc80ef84547b4ed72c7ae0d6746b109c8b1879359c43374d1816fe384cc31b24b87879ddefe993887140c2f0df9c
@practicalswift
Copy link
Contributor

practicalswift commented May 3, 2018

@laanwj git grep will only search in the repo, which is what we want right? :-)

@laanwj
Copy link
Member

laanwj commented May 3, 2018

@practicalswift You're right, that's what it does by default, forgot about that.

UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 21, 2021
…ments after bitcoin#13106

21f5680 Trivial: s/SetBestChain/ChainStateFlushed in comments after bitcoin#13106 (Russell Yanofsky)

Pull request description:

Tree-SHA512: 373896dd73c3ba202739433b22320a4b7ea6dc80ef84547b4ed72c7ae0d6746b109c8b1879359c43374d1816fe384cc31b24b87879ddefe993887140c2f0df9c
TheArbitrator pushed a commit to TheArbitrator/dash that referenced this pull request Jun 4, 2021
…ments after bitcoin#13106

21f5680 Trivial: s/SetBestChain/ChainStateFlushed in comments after bitcoin#13106 (Russell Yanofsky)

Pull request description:

Tree-SHA512: 373896dd73c3ba202739433b22320a4b7ea6dc80ef84547b4ed72c7ae0d6746b109c8b1879359c43374d1816fe384cc31b24b87879ddefe993887140c2f0df9c
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jun 5, 2021
…ments after bitcoin#13106

21f5680 Trivial: s/SetBestChain/ChainStateFlushed in comments after bitcoin#13106 (Russell Yanofsky)

Pull request description:

Tree-SHA512: 373896dd73c3ba202739433b22320a4b7ea6dc80ef84547b4ed72c7ae0d6746b109c8b1879359c43374d1816fe384cc31b24b87879ddefe993887140c2f0df9c
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jun 5, 2021
…ments after bitcoin#13106

21f5680 Trivial: s/SetBestChain/ChainStateFlushed in comments after bitcoin#13106 (Russell Yanofsky)

Pull request description:

Tree-SHA512: 373896dd73c3ba202739433b22320a4b7ea6dc80ef84547b4ed72c7ae0d6746b109c8b1879359c43374d1816fe384cc31b24b87879ddefe993887140c2f0df9c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants