Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default #13251

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
7 participants
@fanquake
Copy link
Member

fanquake commented May 17, 2018

  • "Bech32" isn't very user-friendly; used "native segwit" as in #11937.
  • You don't spend from addresses.
  • No reason to block off Bech32 access with legacy address default.

Rebased from #12208

luke-jr added some commits Jan 17, 2018

GUI: Rephrase Bech32 checkbox text/tooltip
- "Bech32" isn't very user-friendly
- You don't spend from addresses

@fanquake fanquake added this to the 0.16.1 milestone May 17, 2018

@fanquake

This comment has been minimized.

Copy link
Member Author

fanquake commented May 17, 2018

@TheBlueMatt

This comment has been minimized.

Copy link
Contributor

TheBlueMatt commented May 17, 2018

utACK 82dda6b

1 similar comment
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented May 17, 2018

utACK 82dda6b

@MarcoFalke MarcoFalke merged commit 82dda6b into bitcoin:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request May 17, 2018

Merge #13251: GUI: Rephrase Bech32 checkbox texts, and enable it with…
… legacy address default

82dda6b GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr)
7ab1c6f GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr)

Pull request description:

  - "Bech32" isn't very user-friendly; used "native segwit" as in #11937.
  - You don't spend from addresses.
  - No reason to block off Bech32 access with legacy address default.

  Rebased from #12208

Tree-SHA512: c82dd20d967a7f47bcc75b25be0d3a8cf00cfccc1cd14916b87d70b9c56fd53e366b456348b173f36c89b145b76624413780abaed4cea82117a9ecd47dd8fb99
@promag

This comment has been minimized.

Copy link
Member

promag commented May 17, 2018

utACK 82dda6b.

@GreatSock

This comment has been minimized.

Copy link
Contributor

GreatSock commented May 17, 2018

I think a better tooltip would be "Native segwit addresses (Bech32) reduce your transaction fees later on and offer better protection against typos, but are unsupported by old wallets. When unchecked, an address compatible with older wallets will be created instead."

But otherwise utACK 82dda6b

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented May 17, 2018

Post Merge utACK 82dda6b

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented May 18, 2018

Thanks. Sorry I've fallen so far behind on rebases. :(

@fanquake fanquake added this to For backport in High-priority for review May 24, 2018

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request May 24, 2018

GUI: Rephrase Bech32 checkbox text/tooltip
- "Bech32" isn't very user-friendly
- You don't spend from addresses

Github-Pull: bitcoin#13251
Rebased-From: 7ab1c6f

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request May 24, 2018

@fanquake fanquake deleted the fanquake:rephrase-bech-32 branch May 26, 2018

@fanquake fanquake removed this from For backport in High-priority for review May 28, 2018

@fanquake

This comment has been minimized.

Copy link
Member Author

fanquake commented May 28, 2018

Backported in #13319

HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Jun 29, 2018

GUI: Rephrase Bech32 checkbox text/tooltip
- "Bech32" isn't very user-friendly
- You don't spend from addresses

Github-Pull: bitcoin#13251
Rebased-From: 7ab1c6f

HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.