Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Satoshi unit #13264

Merged
merged 2 commits into from May 18, 2018

Conversation

Projects
None yet
@GreatSock
Copy link
Contributor

GreatSock commented May 17, 2018

This adds satoshi as an additional amount unit for the GUI.

GreatSock added some commits May 17, 2018

[qt] BitcoinUnits::format with zero decimals
Formatting with zero decimals will now result in 123 instead of 123.0
[qt] Added satoshi unit
"Satoshi (sat)" will be displayed in dropdowns and status bars.
"sat" will be used when appended to numbers.
@mess110

This comment has been minimized.

Copy link
Contributor

mess110 commented May 17, 2018

ACK c722f00

@kristapsk

This comment has been minimized.

Copy link
Contributor

kristapsk commented May 17, 2018

utACK c722f00

@@ -52,7 +55,8 @@ QString BitcoinUnits::shortName(int unit)
switch(unit)
{
case uBTC: return QString::fromUtf8("bits");

This comment has been minimized.

@Empact

Empact May 17, 2018

Member

I guess the fromUtf8 calls is unnecessary here?

This comment has been minimized.

@GreatSock

GreatSock May 17, 2018

Author Contributor

Seems so. Should I make a commit to get rid of it?

This comment has been minimized.

@laanwj

laanwj May 17, 2018

Member

it's unnecessary but also doesn't really matter, there's no more overhead than QString(...) and anyway, it's not a performance critical function.

@Empact

This comment has been minimized.

Copy link
Member

Empact commented May 17, 2018

utACK c722f00

@ken2812221

This comment has been minimized.

Copy link
Member

ken2812221 commented May 17, 2018

Concept ACK

@laanwj laanwj added the GUI label May 17, 2018

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented May 17, 2018

utACK c722f00

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented May 17, 2018

utACK c722f00

@kallewoof
Copy link
Member

kallewoof left a comment

utACK c722f00

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented May 18, 2018

Tested ACK c722f00

@jonasschnelli jonasschnelli merged commit c722f00 into bitcoin:master May 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request May 18, 2018

Merge #13264: [qt] Satoshi unit
c722f00 [qt] Added satoshi unit "Satoshi (sat)" will be displayed in dropdowns and status bars. "sat" will be used when appended to numbers. (GreatSock)
4ddbcbf [qt] BitcoinUnits::format with zero decimals Formatting with zero decimals will now result in 123 instead of 123.0 (GreatSock)

Pull request description:

  This adds satoshi as an additional amount unit for the GUI.

Tree-SHA512: c166c96c9a434b6ac700e1628e54f2dbb132c5232d949c0b464f61276a91d56f9bab4a62d50780535f1d34eaac6484f693a1e0611cd7c9d1ed5ebee066c0dd08

@GreatSock GreatSock deleted the GreatSock:satoshis branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.