Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[qt] Removed "Pay only the required fee" checkbox #13280
This removes the "Pay only the required fee" checkbox from the custom transaction fee section in the SendCoinsDialog. Instead, a minimum value will be enforced on the custom fee input box.
Before, a user could enter a fee below the minimum required fee but upon pressing send the resulting transaction would still pay the minimum fee. Now, if a user enters a value below the minimum fee the custom fee input box will be set to the minimum fee.
Where the checkbox used to be, there is now a more general warning about low fees. The tooltip is still the same as before.
MarcoFalke left a comment
utACK. Please adjust the code to the developer notes (see two comments)
Also, might want to squash the third commit into one of the earlier ones.
Finally, add empty new lines after the git commit subject line. Otherwise, the commit subject can not be parsed properly.
Concept ACK, less UI clutter is great, and it gets rid of a duplicate tooltip.
Also thanks for switching to
To clarify the minimum fee a bit, as well as make way for a potential future decrease, maybe change the tooltip from:
Removing the checkbox breaks horizontal alignment. The text needs be aligned with "Confirmation time target":
@GreatSock if you don't have time for this in the next month or so, I can take it over.