Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add bench_bitcoin to gitian binaries #13292

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@jonasschnelli
Copy link
Member

jonasschnelli commented May 21, 2018

bench_bitcoin is getting more valuable and it's handy to have around for benchmark comparison.
Partially reverts #7776 and #8175

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented May 21, 2018

Slightly tend to -0 on shipping the bench binary. I believe the bench is only useful when comparing the output of a code change while keeping itself unchanged. Note that the bench framework changes significantly between releases, so there would be not much value in having it shipped.

I assume your motivation is to ship them on https://bitcoin.jonasschnelli.ch/, in which case I suggest to patch the gitian descriptor locally.

@jonasschnelli

This comment has been minimized.

Copy link
Member Author

jonasschnelli commented May 21, 2018

I assume your motivation is to ship them on https://bitcoin.jonasschnelli.ch/, in which case I suggest to patch the gitian descriptor locally.

Not only. I was just confronted with comparing different computer systems (mostly barebones) and the bench would have given me first datapoints (for SHA2, etc.).

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented May 23, 2018

I'm also ~0 on this. I agree that my original rationale, that bench is useless (at the time it had only one or two tests), no longer holds. Still there's not much point in running it for normal users.

The advantage of adding this has to be balanced against the extra space the extra binary will take up in the distributions.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented May 23, 2018

Not only. I was just confronted with comparing different computer systems (mostly barebones) and the bench would have given me first datapoints (for SHA2, etc.).

Oh, thats a good use case I haven't thought of. Though, in that case you are most likely a sys-admin-kind of person and can compile (or gitian build) from source?

@sipa

This comment has been minimized.

Copy link
Member

sipa commented May 24, 2018

No strong opinion, but in general I don't see much value to adding a benchmark (a tool mostly useful for developers) to the release distribution. On the other hand, it also doesn't hurt much.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Jun 5, 2018

On the other hand, it also doesn't hurt much.

Interestingly, the bench_bitcoin is larger than bitcoind here (both on Ubuntu 16.04 and 18.04, though these are dynamic executable sizes, the ones in the distribution will be larger as they link boost etc statically):

7,6M src/bench/bench_bitcoin
6,5M src/bitcoind
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Jun 5, 2018

bench includes the 1Mb block?

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Jun 7, 2018

bench includes the 1Mb block?

Seems like a reasonable explanation. It'd probably add about 11M in that case (to the uncompressed size), in the 0.16.0 archive the bitcoind executable is:

-rwxr-xr-x  1 user user 9,8M feb 22 20:19 bitcoind

@jonasschnelli jonasschnelli force-pushed the jonasschnelli:2018/05/bench_gitian branch to 7f1d638 Jun 11, 2018

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Jun 24, 2018

It looks like there's not much agreement to do this, closing for now.

@laanwj laanwj closed this Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.