Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of SHA256 SelfTest code #13438

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
5 participants
@sipa
Copy link
Member

sipa commented Jun 11, 2018

The existing SelfTest code does not cover the specialized double-SHA256-for-64-byte-inputs transforms added in #13191. Fix this.

@theuni

This comment has been minimized.

Copy link
Member

theuni commented Jun 11, 2018

utACK 5edb0bc0e52a7be44ec22257e21ec9198f86acbb, assuming the tests actually pass. Thanks!

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Jun 12, 2018

slightly tested ACK 5edb0bc0e52a7be44ec22257e21ec9198f86acbb, code looks good, does not seem to add noticable startup time.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Jun 12, 2018

Needs rebase

@sipa sipa force-pushed the sipa:201806_selftestsha branch to 1e1eb63 Jun 12, 2018

@sipa

This comment has been minimized.

Copy link
Member Author

sipa commented Jun 12, 2018

Rebased.

@DrahtBot DrahtBot removed the Needs rebase label Jun 12, 2018

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Jun 18, 2018

re-utACK 1e1eb63

@laanwj laanwj merged commit 1e1eb63 into bitcoin:master Jun 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 18, 2018

Merge #13438: Improve coverage of SHA256 SelfTest code
1e1eb63 Improve coverage of SHA256 SelfTest code (Pieter Wuille)

Pull request description:

  The existing SelfTest code does not cover the specialized double-SHA256-for-64-byte-inputs transforms added in #13191. Fix this.

Tree-SHA512: 593c7ee5dc9e77fc4c89e0a7753a63529b0d3d32ddbc015ae3895b52be77bee8a80bf16b754b30a22c01625a68db83fb77fa945a543143542bebb5b0f017ec5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.