Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Peer table: Visualize inbound/outbound state for every row #13537

Merged
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+2 −1
Diff settings

Always

Just for now

Copy path View file
@@ -162,7 +162,8 @@ QVariant PeerTableModel::data(const QModelIndex &index, int role) const
case NetNodeId:
return (qint64)rec->nodeStats.nodeid;
case Address:
return QString::fromStdString(rec->nodeStats.addrName);
// prepend to peer address down-arrow symbol for inbound connection and up-arrow for outbound connection
return QString(rec->nodeStats.fInbound ? "" : "") + QString::fromStdString(rec->nodeStats.addrName);

This comment has been minimized.

Copy link
@jonasschnelli

jonasschnelli Jun 26, 2018

Member

Does those unicode char (86 93 and 86 91) work on all supported platforms (especially older windows version)?
Would using an Icon make more sense?

This comment has been minimized.

Copy link
@wodry

wodry Jun 26, 2018

Author Contributor

Could You define 'older windows version'?

This comment has been minimized.

Copy link
@fanquake

fanquake Jun 27, 2018

Member

Windows 7 or later is what we are currently supporting.

This comment has been minimized.

Copy link
@wodry

wodry Jun 29, 2018

Author Contributor

I can not test for Windows, since I do not have any Windows. Maybe someone with Windows testing capabilities can apply this one-liner and check?

This comment has been minimized.

Copy link
@laanwj

laanwj Jun 29, 2018

Member

These characters have been in unicode since time immemorial [Unicode 1.1.0 (June, 1993], I wouldn't be afraid of them not being supported.

case Subversion:
return QString::fromStdString(rec->nodeStats.cleanSubVer);
case Ping:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.