Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions #13578
Upgrade the ZeroMQ dependency from version 4.2.3 to the latest stable version 4.2.5.
This PR Follows the lead of #11986.
I upgraded both patch files to correspond to the version
Without updating the patch line numbers, things appear to work, but you get extra log messages while building
Updating the patches seemed cleaner, so I did it. Note that libzmq had some whitespace changes, so that's why the updated patches do too.
tags: libzmq, zmq, 0mq
@mruddy What's the motivation for bumping; is there a specific change/bugfix included in 4.2.3->4.2.5 that you require?
I've had a look at the patches, updating line numbers and formatting from upstream is fine.
Looks like we still also require the postprocess
Which platforms have you tested depends builds/gitian building on? Last time we updated zeromq we were stung with a sneaky change that broke gitian building, hence the need of the
@fanquake My primary motivation is that my dev machine is Ubuntu 18.04 LTS and its
From the 4.2.4 release notes, this one looked a little interesting. Although, I did NOT try to use it to make my node crash, so I don't know if it actually applies: "ZMQ_PUB crash when due to high volume of subscribe and unsubscribe messages, an unmatched unsubscribe message is received in certain conditions".
referenced this pull request
Jul 5, 2018
Combined #13596 into this PR.
I know is late for this but it would be great if we could also add this commit as a patch zeromq/libzmq@58d1339
If you want to squash it in your PR i rebased it against yours in https://github.com/greenaddress/bitcoin/tree/zmq-upgrade-mruddy-patched
I also prepared a separate PR in #13689
@laanwj OK and thanks for reviewing this.
@greenaddress Just wanted to let you know that I'm not ignoring you, I've just been following the conversation over at #13689. I think I'd rather just leave them separate since this PR already has some ACKs and it looks like you're pretty well done with your changes in the other PR too. Thanks for your review too.