Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: bitcoin-tx: Require that input amount is provided for witness transactions #13608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@Empact
Copy link
Member

@Empact Empact commented Jul 7, 2018

Applies fix from #12458 / #13547 to bitcoin-tx.

@Empact
Copy link
Member Author

@Empact Empact commented Jul 7, 2018

wip: needs testing.

@bitcoin bitcoin deleted a comment from WorkShop-Office Jul 7, 2018
@MarcoFalke MarcoFalke changed the title Require that input amount is provided for bitcoin-tx witness transactions bitcoin-tx: Require that input amount is provided for witness transactions Jul 7, 2018
@Empact
Copy link
Member Author

@Empact Empact commented Jul 9, 2018

I'll re-open this after one of #12458 / #13547 goes in.

@Empact Empact closed this Jul 9, 2018
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jul 11, 2018

wip: needs testing.

Jup, would be nice to add a test to the existing test cases.

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Jul 29, 2018

#13547 went in; reopen?

@Empact Empact reopened this Jul 29, 2018
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jul 30, 2018
@Empact Empact changed the title bitcoin-tx: Require that input amount is provided for witness transactions WIP: bitcoin-tx: Require that input amount is provided for witness transactions Nov 12, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Mar 9, 2020

The last travis run for this pull request was 278 days ago and is thus outdated. To trigger a fresh travis build, this pull request should be closed and re-opened.
@DrahtBot DrahtBot closed this Mar 9, 2020
@DrahtBot DrahtBot reopened this Mar 9, 2020
@fanquake
Copy link
Member

@fanquake fanquake commented Jun 9, 2021

@theStack you might be interested in reviewing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants