New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: require macOS 10.10+ #13617
Changes from all commits
26b15df
84b0cfa
6c6dbd8
68c2725
fa6e841
3828a79
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,9 +120,6 @@ namespace GUIUtil | |
// Open the config file | ||
bool openBitcoinConf(); | ||
|
||
// Replace invalid default fonts with known good ones | ||
void SubstituteFonts(const QString& language); | ||
|
||
/** Qt event filter that intercepts ToolTipChange events, and replaces the tooltip with a rich text | ||
representation if needed. This assures that Qt can word-wrap long tooltip messages. | ||
Tooltips longer than the provided size threshold (in characters) are wrapped. | ||
|
@@ -233,19 +230,7 @@ namespace GUIUtil | |
void mouseReleaseEvent(QMouseEvent *event); | ||
}; | ||
|
||
#if defined(Q_OS_MAC) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Has someone verified that this BUG no longer appears on OSX 10.10+? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jonasschnelli I haven't been able to recreate it yet, will test further though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new URL for the bug appears to be https://bugreports.qt.io/browse/QTBUG-15631 but that bug seems unrelated to the comment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kallewoof I mentioned in the PR description, from what I can tell the correct link is https://bugreports.qt.io/browse/QTBUG-20880 |
||
// workaround for Qt OSX Bug: | ||
// https://bugreports.qt-project.org/browse/QTBUG-15631 | ||
// QProgressBar uses around 10% CPU even when app is in background | ||
class ProgressBar : public ClickableProgressBar | ||
{ | ||
bool event(QEvent *e) { | ||
return (e->type() != QEvent::StyleAnimationUpdate) ? QProgressBar::event(e) : false; | ||
} | ||
}; | ||
#else | ||
typedef ClickableProgressBar ProgressBar; | ||
#endif | ||
|
||
} // namespace GUIUtil | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theuni In the readme it's cosmetic, darwin11 refers to OS X 10.7, darwin14 should be 10.10.
However good catch, as we should also be changing this in travis.yml and gitian-osx.yml ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, how does this even compile on travis/gitian, given that support for 10.7 has been removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never seen a case where this changes anything in practice. As a test, I just had a look at gcc's configure.ac though, and it at least checks for >=10 in a few places. So I guess we should keep these in sync to be on the safe side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in travis.yml and gitian-osx.yml